drm: restrict the device list for shadow attached drivers
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 11 lines · Linux Kernel
Gitweb: http://git.kernel.org/linus/;a=commit;h=b3f2333de8e81b089262b26d52272911523e605f Commit: b3f2333de8e81b089262b26d52272911523e605f Parent: e2577d455adb165e1046816e5ed092cc6d60f35a Author: Daniel Vetter <[email protected]> AuthorDate: Wed Dec 11 11:34:31 2013 +0100 Committer: Dave Airlie <[email protected]> CommitDate: Wed Dec 18 11:08:36 2013 +1000drm: restrict the device list for shadow attached drivers
Review void drm_pci_exit(struct drm_driver *driver, struct pci_driver *pdriver) · line 478
Quoted 10 lines
(quoted diff) +4
-1@@ -465,8 +470,11 @@ void drm_pci_exit(struct drm_driver *driver, struct pci_driver *pdriver) if (driver->driver_features & DRIVER_MODESET) { pci_unregister_driver(pdriver); } else { - list_for_each_entry_safe(dev, tmp, &driver->device_list, driver_item) + list_for_each_entry_safe(dev, tmp, &driver->legacy_dev_list, + legacy_dev_list) { drm_put_dev(dev); + list_del(&dev->legacy_dev_list); + } }
Use-after-free. drm_put_dev frees dev.
Dave