Commit 3865ceb7 breaks vexpress_aemv8a build with warnings

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, January 30, 2014 8:06 PM
To: U-Boot
Cc: Sharma Bhupesh-B45370; Tom Rini
Subject: Commit 3865ceb7 breaks vexpress_aemv8a build with warnings

Hello,

I have just noticed that vexpress_aemv8a seems broken with v2014.01, using gcc version 4.8.1 (Ubuntu/Linaro 4.8.1-10ubuntu9).

The symptom is a lot of warnings like

smc91111_eeprom.c: In function 'dump_reg':
/home/albert/src/u-boot-arm/include/../drivers/net/smc91111.h:261:28:
warning: cast to pointer from integer of different size [-Wint-to- pointer-cast] #define SMC_outw(a,d,r) (*((volatile word *)((a)->iobase+(r))) = d)
^ /home/albert/src/u-boot-arm/include/../drivers/net/smc91111.h:747:33:
note: in expansion of macro 'SMC_outw' #define SMC_SELECT_BANK(a,x) { SMC_outw((a), (x), BANK_SELECT ); }

A rough search shows that the issue originates in commit 3865ceb7 ("vexpress/armv8: Fix incorrect ethernet controller") submitted by Bhupesh Sharma and committed by Tom Rini, both Cc:ed.

Bupesh, can you investigate?

Quoted 27 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Thursday, January 30, 2014 8:06 PM
To: U-Boot
Cc: Sharma Bhupesh-B45370; Tom Rini
Subject: Commit 3865ceb7 breaks vexpress_aemv8a build with warnings

Hello,

I have just noticed that vexpress_aemv8a seems broken with v2014.01, using gcc version 4.8.1 (Ubuntu/Linaro 4.8.1-10ubuntu9).

The symptom is a lot of warnings like

smc91111_eeprom.c: In function 'dump_reg':
/home/albert/src/u-boot-arm/include/../drivers/net/smc91111.h:261:28:
warning: cast to pointer from integer of different size [-Wint-to- pointer-cast] #define SMC_outw(a,d,r) (*((volatile word *)((a)->iobase+(r))) = d)
^ /home/albert/src/u-boot-arm/include/../drivers/net/smc91111.h:747:33:
note: in expansion of macro 'SMC_outw' #define SMC_SELECT_BANK(a,x) { SMC_outw((a), (x), BANK_SELECT ); }

A rough search shows that the issue originates in commit 3865ceb7 ("vexpress/armv8: Fix incorrect ethernet controller") submitted by Bhupesh Sharma and committed by Tom Rini, both Cc:ed.

Quoted 2 lines

Bupesh, can you investigate?

I did post a reply to a mail on similar lines before:
http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/178502

I did not get much time to look into the same.
Let me try the same tomorrow.

Regards,
Bhupesh