drm/radeon/dpm: fix uninitialized read from stack in kv_dpm_late_enable
Subsystems (2)
If we take the false branch of the if quoted in the diff below, we end up doing a return ret, without ever having initialized it.
Picked up by coverity.
Signed-off-by Dave Jones <[email protected]>
drivers/gpu/drm/radeon/kv_dpm.c +1 -1
@@ -1223,7 +1223,7 @@ int kv_dpm_enable(struct radeon_device *rdev)int kv_dpm_late_enable (struct radeon_device *rdev) { -int ret; +int ret =0 ;if (rdev->irq.installed &&r600_is_internal_thermal_sensor (rdev->pm.int_thermal_type)) {
Quoted 8 lines
-----Original Message-----
From: Dave Jones [mailto:[email protected]]
Sent: Thursday, January 30, 2014 9:18 PM
To: Linux Kernel Mailing List
Cc: Deucher, Alexander
Subject: drm/radeon/dpm: fix uninitialized read from stack inkv_dpm_late_enable
Quoted 6 lines
If we take the false branch of the if quoted in the diff below, we end up doing a return ret, without ever having initialized it.
Picked up by coverity.
Signed-off-by Dave Jones <[email protected]>
Applied. Thanks!
Alex
Quoted 15 lines
drivers/gpu/drm/radeon/kv_dpm.c +1
-1@@ -1223,7 +1223,7 @@ int kv_dpm_enable(struct radeon_device *rdev)int kv_dpm_late_enable (struct radeon_device *rdev) { -int ret; +int ret =0 ;if (rdev->irq.installed &&r600_is_internal_thermal_sensor (rdev->pm.int_thermal_type)) {