vmwgfx: Fix unitialized stack read in vmw_setup_otable_base
Subsystems (3)
One of the error paths in vmw_setup_otable_base causes us to return with 'ret' having never been set to anything causing us to return whatever was on the stack.
Found with Coverity
Signed-off-by Dave Jones <[email protected]>
drivers/gpu/drm/vmwgfx/vmwgfx_mob.c +1 -0
@@ -134,6 +134,7 @@ static int vmw_setup_otable_base(struct vmw_private *dev_priv, cmd =vmw_fifo_reserve (dev_priv,sizeof (*cmd));if (unlikely (cmd ==NULL )) {DRM_ERROR ("Failed reserving FIFO space for OTable setup.\n" ); + ret = -ENOMEM ; goto out_no_fifo; }
Quoted 13 lines · Dave Jones
One of the error paths in
vmw_setup_otable_basecauses us to return with 'ret' having never been set to anything causing us to return whatever was on the stack.Found with Coverity
Signed-off-by Dave Jones <[email protected]>drivers/gpu/drm/vmwgfx/vmwgfx_mob.c +0
-0
drivers/gpu/drm/vmwgfx/vmwgfx_mob.c static int vmw_setup_otable_base(struct vmw_private *dev_priv, · line 140
Quoted 7 lines
drivers/gpu/drm/vmwgfx/vmwgfx_mob.c +1
-0@@ -134,6 +134,7 @@ static int vmw_setup_otable_base(struct vmw_private *dev_priv, cmd =vmw_fifo_reserve (dev_priv,sizeof (*cmd));if (unlikely (cmd ==NULL )) {DRM_ERROR ("Failed reserving FIFO space for OTable setup.\n" ); + ret = -ENOMEM ; goto out_no_fifo; }
Thanks,
Will queue on vmwgfx-fixes for -rc2.
/Thomas