drm/nouveau/hwmon: remove some redundant checks
Subsystems (4)
PATCH 1/1 drm/nouveau/hwmon: remove some redundant checks
No need to check "ret" twice in a row.
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/nouveau/nouveau_hwmon.c +4 -8
@@ -587,18 +587,14 @@ nouveau_hwmon_init(struct drm_device *dev)/* set the default attributes */ ret =sysfs_create_group (&hwmon_dev->kobj, &hwmon_default_attrgroup); -if (ret) { -if (ret) - goto error; - } +if (ret) + goto error;/* if the card has a working thermal sensor */ if (therm->temp_get (therm) >=0 ) { ret =sysfs_create_group (&hwmon_dev->kobj, &hwmon_temp_attrgroup); -if (ret) { -if (ret) - goto error; - } +if (ret) + goto error; }/* if the card has a pwm fan */
----- Original Message -----
Quoted 9 lines
From: "Dan Carpenter" <[email protected]>
To: "David Airlie" <[email protected]>
Cc: "Ben Skeggs" <[email protected]>, "Martin Peres" <[email protected]>, "Ilia Mirkin" <[email protected]>, "Dave Airlie" <[email protected]>, [email protected], [email protected]
Sent: Thursday, 6 February, 2014 7:29:43 PM
Subject: [patch] drm/nouveau/hwmon: remove some redundant checksNo need to check "ret" twice in a row.
Got it. Thank you!
Quoted 31 lines
Signed-off-by Dan Carpenter <[email protected]>drivers/gpu/drm/nouveau/nouveau_hwmon.c +4
-8@@ -587,18 +587,14 @@ nouveau_hwmon_init(struct drm_device *dev)/* set the default attributes */ ret =sysfs_create_group (&hwmon_dev->kobj, &hwmon_default_attrgroup); -if (ret) { -if (ret) - goto error; - } +if (ret) + goto error;/* if the card has a working thermal sensor */ if (therm->temp_get (therm) >=0 ) { ret =sysfs_create_group (&hwmon_dev->kobj, &hwmon_temp_attrgroup); -if (ret) { -if (ret) - goto error; - } +if (ret) + goto error; }/* if the card has a pwm fan */