Skip to contentSkip to conversation

3c59x: Remove unused pointer in vortex_eisa_cleanup()

PATCH Applied Christian Engelmayer 3 participants 4 messages Feb 8, 2014 – Feb 10, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 3c59x: Remove unused pointer in vortex_eisa_cleanup()

Remove unused network device private data pointer 'vp' in function vortex_eisa_cleanup(). Detected by Coverity: CID 139826.

---
 drivers/net/ethernet/3com/3c59x.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/ethernet/3com/3c59x.c +0 -2
index 0f4241c..238ccea 100644
@@ -3294,7 +3294,6 @@ static int __init vortex_init(void)
 
 static void __exit vortex_eisa_cleanup(void)
 {
-	struct vortex_private *vp;
 	void __iomem *ioaddr;
 
 #ifdef CONFIG_EISA
@@ -3303,7 +3302,6 @@ static void __exit vortex_eisa_cleanup(void)
 #endif
 
 	if (compaq_net_device) {
-		vp = netdev_priv(compaq_net_device);
 		ioaddr = ioport_map(compaq_net_device->base_addr,
 		                    VORTEX_TOTAL_SIZE);
 
Signature · 1 line
1.8.3.2
#1 lore raw

Remove unused network device private data pointer 'vp' in function vortex_eisa_cleanup(). Detected by Coverity: CID 139826.

---
Resend using address [email protected] as retrieved from the mail delivery fail notification by tu-chemnitz.de. Information in MAINTAINERS seems to be outdated on that point.

---
 drivers/net/ethernet/3com/3c59x.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/ethernet/3com/3c59x.c +0 -2
index 0f4241c..238ccea 100644
@@ -3294,7 +3294,6 @@ static int __init vortex_init(void)
 
 static void __exit vortex_eisa_cleanup(void)
 {
-	struct vortex_private *vp;
 	void __iomem *ioaddr;
 
 #ifdef CONFIG_EISA
@@ -3303,7 +3302,6 @@ static void __exit vortex_eisa_cleanup(void)
 #endif
 
 	if (compaq_net_device) {
-		vp = netdev_priv(compaq_net_device);
 		ioaddr = ioport_map(compaq_net_device->base_addr,
 		                    VORTEX_TOTAL_SIZE);
 
Signature · 1 line
1.8.3.2
#2 lore raw
In reply to Christian Engelmayer
Quoted 8 lines · Christian Engelmayer

Remove unused network device private data pointer 'vp' in function vortex_eisa_cleanup(). Detected by Coverity: CID 139826.

---
Resend using address [email protected] as retrieved from the mail delivery fail notification by tu-chemnitz.de. Information in MAINTAINERS seems to be outdated on that point.

Oh yes, it expired at the beginning of the year. I'll do a patch to update the maintainers entry. Thanks for the info!