Skip to contentSkip to conversation

ATMEL AT45DB041D spi flash and gplugd

U-Boot Yogi P 2 participants 4 messages Feb 9, 2014 – Mar 17, 2014

lore
Share & tools
lore
#1 lore raw

Hi Yogi,

Quoted 15 lines · Yogi P

Hello all,

From following commit spi write/erase times out on gplugd which uses ATMEL AT45DB041D spi flash.

Quoted 10 lines

commit f4f51a8ff894d34eb332f0d11f6c73c7bf509848

Author: Jagannadha Sutradharudu Teki <[email protected]>
Date:   Wed Oct 2 19:36:58 2013 +0530

sf: probe: Add support for erase sector selection flag

SECT_4K, SECT_32K and SECT_64K opeartions are performed to to specific flash by adding a SECT* flag on respective spi_flash_params.flag param.

Quoted 8 lines
Quoted 1 line

Prior to this patch erase size was same as sector size; which is 64 * 1024 (64k). This 64K was replaced with 4k and timeout for erase started.

If following patch is applied write/erase works well (See bottom) on top of above commit. But similar change on latest git head still has some problem with spi erase.

Does this means CMD_ERASE_64K works on master?
Can you verify correctly - because we couldn't find any issues so far as per as the sf_ops
code is concern.

Quoted 14 lines
drivers/mtd/spi/spi_flash_probe.c +1 -1
index 9c2e115..9e1c4c5 100644
@@ -41,7 +41,7 @@ static const struct spi_flash_params spi_flash_params_table[] = {
 #ifdef CONFIG_SPI_FLASH_ATMEL          /* ATMEL */
        {"AT45DB011D",     0x1f2200, 0x0,       64 * 1024,     4,              SECT_4K},
        {"AT45DB021D",     0x1f2300, 0x0,       64 * 1024,     8,              SECT_4K},
-       {"AT45DB041D",     0x1f2400, 0x0,       64 * 1024,     8,              SECT_4K},
+       {"AT45DB041D",     0x1f2400, 0x0,       64 * 1024,     8,              0},
        {"AT45DB081D",     0x1f2500, 0x0,       64 * 1024,    16,              SECT_4K},
        {"AT45DB161D",     0x1f2600, 0x0,       64 * 1024,    32,              SECT_4K},
        {"AT45DB321D",     0x1f2700, 0x0,       64 * 1024,    64,              SECT_4K},
Quoted 4 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

thanks!

Signature · 1 line
Jagan.
author
#2 lore raw

Hi Jagan,

Quoted 25 lines · Jagan Teki

Hi Yogi,

Quoted 3 lines · Yogi P

Hello all,

From following commit spi write/erase times out on gplugd which uses

ATMEL

Quoted 8 lines

AT45DB041D spi flash.

Quoted 6 lines

commit f4f51a8ff894d34eb332f0d11f6c73c7bf509848

Author: Jagannadha Sutradharudu Teki <[email protected]>
Date:   Wed Oct 2 19:36:58 2013 +0530

sf: probe: Add support for erase sector selection flag

Quoted 7 lines
Quoted 5 lines

SECT_4K, SECT_32K and SECT_64K opeartions are performed to to specific flash by adding a SECT* flag on respective spi_flash_params.flag param.

Prior to this patch erase size was same as sector size; which is 64 *

1024 (64k).

Quoted 2 lines

This 64K was replaced with 4k and timeout for erase started.

Quoted 8 lines
Quoted 1 line

If following patch is applied write/erase works well (See bottom) on top

of

Quoted 1 line

above commit. But similar change on latest git head still has some

problem

Quoted 1 line

with spi erase.

Does this means CMD_ERASE_64K works on master?

No its not working on master.

Can you verify correctly - because we couldn't find any issues so far

Quoted 3 lines

as per as the sf_ops
code is concern.

Its stopped working from f4f51a8ff894d34eb332f0d11f6c73c7bf509848. But to get it working on this particular commit following patch is needed.

But even with this patch, master is broken.

Thanks
Yogi

Quoted 34 lines

Review

Quoted 2 lines
(quoted diff) +0 -0

b/drivers/mtd/spi/spi_flash_probe.c

drivers/mtd/spi/spi_flash_probe.c static const struct spi_flash_params

Quoted 4 lines

index 9c2e115..9e1c4c5 100644

drivers/mtd/spi/spi_flash_probe.c +0 -0
@@ -41,7 +41,7 @@ static const struct spi_flash_params

spi_flash_params_table[] = {

drivers/mtd/spi/spi_flash_probe.c static const struct spi_flash_params · line 42

Quoted 2 lines
drivers/mtd/spi/spi_flash_probe.c +0 -0
 #ifdef CONFIG_SPI_FLASH_ATMEL          /* ATMEL */
        {"AT45DB011D",     0x1f2200, 0x0,       64 * 1024,     4,
       SECT_4K},

drivers/mtd/spi/spi_flash_probe.c static const struct spi_flash_params · line 43

Quoted 1 line
drivers/mtd/spi/spi_flash_probe.c +0 -0
        {"AT45DB021D",     0x1f2300, 0x0,       64 * 1024,     8,
       SECT_4K},

drivers/mtd/spi/spi_flash_probe.c static const struct spi_flash_params · line 44

Quoted 1 line
drivers/mtd/spi/spi_flash_probe.c +0 -1
-       {"AT45DB041D",     0x1f2400, 0x0,       64 * 1024,     8,
       SECT_4K},

drivers/mtd/spi/spi_flash_probe.c static const struct spi_flash_params · line 44

Quoted 1 line
drivers/mtd/spi/spi_flash_probe.c +1 -0
+       {"AT45DB041D",     0x1f2400, 0x0,       64 * 1024,     8,
       0},

drivers/mtd/spi/spi_flash_probe.c static const struct spi_flash_params · line 45

Quoted 1 line
drivers/mtd/spi/spi_flash_probe.c +0 -0
        {"AT45DB081D",     0x1f2500, 0x0,       64 * 1024,    16,
       SECT_4K},

drivers/mtd/spi/spi_flash_probe.c static const struct spi_flash_params · line 46

Quoted 1 line
drivers/mtd/spi/spi_flash_probe.c +0 -0
        {"AT45DB161D",     0x1f2600, 0x0,       64 * 1024,    32,
       SECT_4K},

drivers/mtd/spi/spi_flash_probe.c static const struct spi_flash_params · line 47

Quoted 1 line
drivers/mtd/spi/spi_flash_probe.c +0 -0
        {"AT45DB321D",     0x1f2700, 0x0,       64 * 1024,    64,
       SECT_4K},
Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

thanks!
--
Jagan.

Signature · 2 lines
Thanks
Yogi
#3 lore raw

Hi Yogi,

Quoted 67 lines · yogi p

Hi Jagan,

Quoted 26 lines · Jagan Teki

Hi Yogi,

Quoted 22 lines · Yogi P

Hello all,

From following commit spi write/erase times out on gplugd which uses ATMEL
AT45DB041D spi flash.

Quoted 11 lines

commit f4f51a8ff894d34eb332f0d11f6c73c7bf509848

Author: Jagannadha Sutradharudu Teki <[email protected]>
Date:   Wed Oct 2 19:36:58 2013 +0530

sf: probe: Add support for erase sector selection flag

SECT_4K, SECT_32K and SECT_64K opeartions are performed to to specific flash by adding a SECT* flag on respective spi_flash_params.flag param.

Prior to this patch erase size was same as sector size; which is 64 * 1024 (64k).
This 64K was replaced with 4k and timeout for erase started.

Quoted 7 lines
Quoted 5 lines

If following patch is applied write/erase works well (See bottom) on top of
above commit. But similar change on latest git head still has some problem
with spi erase.

Does this means CMD_ERASE_64K works on master?

No its not working on master.

Quoted 3 lines

Can you verify correctly - because we couldn't find any issues so far as per as the sf_ops
code is concern.

Its stopped working from f4f51a8ff894d34eb332f0d11f6c73c7bf509848. But to get it working on this particular commit following patch is needed.

But even with this patch, master is broken.

Thanks
Yogi

Quoted 16 lines
Quoted 16 lines
drivers/mtd/spi/spi_flash_probe.c +0 -1
index 9c2e115..9e1c4c5 100644
@@ -41,7 +41,7 @@ static const struct spi_flash_params
 spi_flash_params_table[] = {
 #ifdef CONFIG_SPI_FLASH_ATMEL          /* ATMEL */
        {"AT45DB011D",     0x1f2200, 0x0,       64 * 1024,     4,
 SECT_4K},
        {"AT45DB021D",     0x1f2300, 0x0,       64 * 1024,     8,
 SECT_4K},
-       {"AT45DB041D",     0x1f2400, 0x0,       64 * 1024,     8,

SECT_4K},

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

+ {"AT45DB041D", 0x1f2400, 0x0, 64 * 1024, 8,
0},

        {"AT45DB081D",     0x1f2500, 0x0,       64 * 1024,    16,
SECT_4K},
        {"AT45DB161D",     0x1f2600, 0x0,       64 * 1024,    32,
SECT_4K},
        {"AT45DB321D",     0x1f2700, 0x0,       64 * 1024,    64,

SECT_4K},

I'm recollecting bug information you pointed, please correct what I'm saying here.

Current tree for AT45DB041D part has configured
flash->erase_cmd = CMD_ERASE_4K;
flash->erase_size = 4096;

The same configuration is not working for your board, is that true? Did you see working tree in earlier tag releases?

Signature · 1 line
Jagan.