Skip to contentSkip to conversation

Additional item for rtl8188eu TODO list

PATCH New Paul E. McKenney 1 participant 1 message Feb 12, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Additional item for rtl8188eu TODO list

Hello!

The rtw_recv_indicatepkt() function in the file named drivers/staging/rtl8188eu/os_dep/recv_linux.c has this strange code:

	rcu_read_lock();
	rcu_dereference(padapter->pnetdev->rx_handler_data);
	rcu_read_unlock();

This code has no effect. Normally, you would assign the result of rcu_dereference() to some variable, but it is not clear from the code what variable that would be. Therefore, this patch applies to the TODO file instead of the code itself.

drivers/staging/rtl8188eu/TODO +5 -0
index f7f389c40e71..b574b235b340 100644
@@ -9,6 +9,11 @@ TODO:
 - merge Realtek's bugfixes and new features into the driver
 - switch to use LIB80211
 - switch to use MAC80211
+- figure out what to do with this code in rtw_recv_indicatepkt():
+	rcu_read_lock();
+	rcu_dereference(padapter->pnetdev->rx_handler_data);
+	rcu_read_unlock();
+  Perhaps delete it, perhaps assign to some local variable.
 
 Please send any patches to Greg Kroah-Hartman <[email protected]>,
 and Larry Finger <[email protected]>.