Skip to contentSkip to conversation

mmc: rtsx: add support for pre_req and post_req

DISCUSSION Dan Carpenter 1 participant 1 message Feb 24, 2014 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

Hello Micky Ching,

This is a semi-automatic email about new static checker warnings.

The patch c42deffd5b53: "mmc: rtsx: add support for pre_req and post_req" from Feb 17, 2014, leads to the following Smatch complaint:

drivers/mmc/host/rtsx_pci_sdmmc.c:504 sd_get_rsp()
error: we previously assumed 'cmd' could be null (see line 434)

drivers/mmc/host/rtsx_pci_sdmmc.c
433

   434		if (!cmd) {
                     ^^^

Patch introduces check.

   435			dev_err(sdmmc_dev(host), "error: cmd not exist\n");
   436			goto out;
   437		}
   438	

[ snip ]

497 if (cmd->data) {
498 sd_start_multi_rw(host, host->mrq);
499 spin_unlock_irqrestore(&host->lock, flags);
500 return;
501 }
502
503 out:

   504		cmd->error = err;
                ^^^^^^^^^^

Dereference was already there.

   505	
   506		tasklet_schedule(&host->finish_tasklet);

regards,
dan carpenter