Skip to contentSkip to conversation

ASoC: sst-haswell-ipc: incorrect sizeof()

PATCH Applied Dan Carpenter 1 participant 1 message Feb 25, 2014

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 ASoC: sst-haswell-ipc: incorrect sizeof()

This should be sizeof(pos) instead of sizeof(&pos). Most likely they are both 8 bytes though so it doesn't often make a difference in real life.

Fixes 22981243589c ('ASoC: Intel: Add Haswell/Broadwell IPC')
sound/soc/intel/sst-haswell-ipc.c +1 -1
index 552aebf2c8f5..1f1576a9586a 100644
@@ -617,7 +617,7 @@ static void hsw_notification_work(struct work_struct *work)
 	case IPC_POSITION_CHANGED:
 		trace_ipc_notification("DSP stream position changed for",
 			stream->reply.stream_hw_id);
-		sst_dsp_inbox_read(hsw->dsp, pos, sizeof(&pos));
+		sst_dsp_inbox_read(hsw->dsp, pos, sizeof(pos));
 
 		if (stream->notify_position)
 			stream->notify_position(stream, stream->pdata);