Skip to contentSkip to conversation

ext3: remove an unneeded check in ext3_new_blocks()

PATCH In review Dan Carpenter 2 participants 2 messages Feb 25, 2014 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext3: remove an unneeded check in ext3_new_blocks()

We know "fatal" is zero here. The code can be simplified a bit by assigning directly.

fs/ext3/balloc.c +1 -4
index 22548f56197b..158b5d4ce067 100644
@@ -1727,10 +1727,7 @@ allocated:
 	percpu_counter_sub(&sbi->s_freeblocks_counter, num);
 
 	BUFFER_TRACE(gdp_bh, "journal_dirty_metadata for group descriptor");
-	err = ext3_journal_dirty_metadata(handle, gdp_bh);
-	if (!fatal)
-		fatal = err;
-
+	fatal = ext3_journal_dirty_metadata(handle, gdp_bh);
 	if (fatal)
 		goto out;
 
#1 lore raw
Quoted 4 lines · Dan Carpenter

We know "fatal" is zero here. The code can be simplified a bit by assigning directly.

Thanks. Added to my tree.

Honza

Quoted 17 lines
fs/ext3/balloc.c +1 -4
index 22548f56197b..158b5d4ce067 100644
@@ -1727,10 +1727,7 @@ allocated:
 	percpu_counter_sub(&sbi->s_freeblocks_counter, num);
 
 	BUFFER_TRACE(gdp_bh, "journal_dirty_metadata for group descriptor");
-	err = ext3_journal_dirty_metadata(handle, gdp_bh);
-	if (!fatal)
-		fatal = err;
-
+	fatal = ext3_journal_dirty_metadata(handle, gdp_bh);
 	if (fatal)
 		goto out;
 
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR