Skip to contentSkip to conversation

ALSA: compress: no need to set metadata before next track

PATCH New Richard Fitzgerald 1 participant 1 message Feb 26, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: compress: no need to set metadata before next track

The metadata is mainly for MP3 gapless playback, since the MP3 audio stream does not contain enough information to enable gapless. Other audio formats do not necessarily require any additional metadata so we should allow next_track to be called without any metadata.

---
 sound/core/compress_offload.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
sound/core/compress_offload.c +0 -6
index 7a20897..5a351c7 100644
@@ -744,12 +744,6 @@ static int snd_compr_next_track(struct snd_compr_stream *stream)
 	if (stream->runtime->state != SNDRV_PCM_STATE_RUNNING)
 		return -EPERM;
 
-	/* you can signal next track isf this is intended to be a gapless stream
-	 * and current track metadata is set
-	 */
-	if (stream->metadata_set == false)
-		return -EPERM;
-
 	retval = stream->ops->trigger(stream, SND_COMPR_TRIGGER_NEXT_TRACK);
 	if (retval != 0)
 		return retval;
Signature · 1 line
1.7.2.5