Skip to contentSkip to conversation

bonding: disallow enslaving a bond to itself

PATCH Applied Jiri Bohac 3 participants 3 messages Feb 26, 2014 – Feb 27, 2014

Subsystems (3)
lore
Share & tools
lore

Jiri Bohac

author
#0 lore raw

PATCH 1/1 bonding: disallow enslaving a bond to itself

Enslaving a bond to itself leads to an endless loop and hangs the kernel.

drivers/net/bonding/bond_main.c +5 -0
index 1c6104d..8f028ac 100644
@@ -1193,6 +1193,11 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
 		return -EBUSY;
 	}
 
+	if (bond_dev == slave_dev) {
+		pr_err("%s: cannot enslave bond to itself.\n", bond_dev->name);
+		return -EPERM;
+	}
+
 	/* vlan challenged mutual exclusion */
 	/* no need to lock since we're protected by rtnl_lock */
 	if (slave_dev->features & NETIF_F_VLAN_CHALLENGED) {
Signature · 2 lines
Jiri Bohac <[email protected]>
SUSE Labs, SUSE CZ
Tested-by on v1 1/1
#1 lore raw
Quoted 2 lines · Jiri Bohac

Enslaving a bond to itself leads to an endless loop and hangs the kernel.

Yes, I met the same problem.

Quoted 19 lines
drivers/net/bonding/bond_main.c +5 -0
index 1c6104d..8f028ac 100644
@@ -1193,6 +1193,11 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
 		return -EBUSY;
 	}
 
+	if (bond_dev == slave_dev) {
+		pr_err("%s: cannot enslave bond to itself.\n", bond_dev->name);
+		return -EPERM;
+	}
+
 	/* vlan challenged mutual exclusion */
 	/* no need to lock since we're protected by rtnl_lock */
 	if (slave_dev->features & NETIF_F_VLAN_CHALLENGED) {