Skip to contentSkip to conversation

arptables: long option "--set-counters" were missing

PATCH Applied Jesper Dangaard Brouer 2 participants 2 messages Feb 28, 2014 – Mar 2, 2014

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Jesper Dangaard Brouer

author
#0 lore raw

PATCH 1/1 arptables: long option "--set-counters" were missing

The long option "--set-counters" where missing in option parsing. And the corresponding short option "-c" were not mentioned in the help usage text.

Also update the arptables man page with a description of the parameter.

Signed-off-by Jesper Dangaard Brouer <[email protected]>

---
Resending patch... didn't get any response from Bart De Schuymer last time...

 userspace/arptables/arptables.8 |    8 ++++++++
 userspace/arptables/arptables.c |    3 ++-
 2 files changed, 10 insertions(+), 1 deletion(-)
userspace/arptables/arptables.8 +8 -0
index 0b6b62e..78b2c60 100644
@@ -215,6 +215,14 @@ The target of the rule. This is one of the following values:
 a target extension (see
 .BR "TARGET EXTENSIONS" ")"
 or a user-defined chain name.
+.TP
+.BI "-c, --set-counters " "PKTS BYTES"
+This enables the administrator to initialize the packet and byte
+counters of a rule (during
+.B INSERT,
+.B APPEND,
+.B REPLACE
+operations).
 
 .SS RULE-SPECIFICATIONS
 The following command line arguments make up a rule specification (as used
userspace/arptables/arptables.c +2 -1
index 4da6fea..3fb8ed5 100644
@@ -152,6 +152,7 @@ static struct option original_opts[] = {
 	{ "help", 2, 0, 'h' },
 	{ "line-numbers", 0, 0, '0' },
 	{ "modprobe", 1, 0, 'M' },
+	{ "set-counters", 1, 0, 'c' },
 	{ 0 }
 };
 

@@ -529,7 +530,7 @@ exit_printhelp(void)
 "  --line-numbers		print line numbers when listing\n"
 "  --exact	-x		expand numbers (display exact values)\n"
 "  --modprobe=<command>		try to insert modules using this command\n"
-"  --set-counters PKTS BYTES	set the counter during insert/append\n"
+"  --set-counters -c PKTS BYTES	set the counter during insert/append\n"
 "[!] --version	-V		print package version.\n");
 	printf(" opcode strings: \n");
         for (i = 0; i < NUMOPCODES; i++)
Applied
#1 lore raw

Jesper Dangaard Brouer schreef op 28/02/2014 13:32:

Quoted 6 lines

The long option "--set-counters" where missing in option parsing. And the corresponding short option "-c" were not mentioned in the help usage text.

Also update the arptables man page with a description of the parameter.

Applied.

Thanks,
Bart