ddbridge: remove unneeded an NULL check

PATCH New Dan Carpenter 1 participant 1 message Mar 1, 2014

Subsystems (3)

Media (V4L/DVB) Kernel janitors Media drivers for digital devices PCIe devices

lore

Share & tools

lore

Dan Carpenter

author

2014-03-01 13:55 UTC #0 lore raw

PATCH 1/1 ddbridge: remove unneeded an NULL check

Static checkers complain about the inconsistent NULL check here.

There is an unchecked dereference of "intput->fe" in the call to tuner_attach_tda18271() and there is a second unchecked dereference a couple lines later when we do:

	input->fe2->tuner_priv = input->fe->tuner_priv;

But actually "intput->fe" can't be NULL because if demod_attach_drxk() fails to allocate it, then we would have return an error code.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/pci/ddbridge/ddbridge-core.c +2 -4

index 9375f30d9a81..fb52bda8d45f 100644
@@ -876,10 +876,8 @@ static int dvb_input_attach(struct ddb_input *input)
 			return -ENODEV;
 		if (tuner_attach_tda18271(input) < 0)
 			return -ENODEV;
-		if (input->fe) {
-			if (dvb_register_frontend(adap, input->fe) < 0)
-				return -ENODEV;
-		}
+		if (dvb_register_frontend(adap, input->fe) < 0)
+			return -ENODEV;
 		if (input->fe2) {
 			if (dvb_register_frontend(adap, input->fe2) < 0)
 				return -ENODEV;