Skip to contentSkip to conversation

arch-at91: Gets ethernet working on at91sam9g20 board

PATCH New John de la Garza 3 participants 3 messages Mar 6, 2014 – Mar 8, 2014

Subsystems (2)
Arm (32-bit) Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

John de la Garza

author
#0 lore raw

PATCH 1/1 arch-at91: Gets ethernet working on at91sam9g20 board

Signed-off-by John de la Garza <[email protected]>
---
 arch/arm/include/asm/arch-at91/at91_rstc.h |    2 +-
 include/configs/at91sam9260ek.h            |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
arch/arm/include/asm/arch-at91/at91_rstc.h +1 -1
index a942342..59be96b 100644
@@ -25,7 +25,7 @@ typedef struct at91_rstc {
 
 #endif /* __ASSEMBLY__ */
 
-#define AT91_RSTC_KEY		0xA5000000
+#define AT91_RSTC_KEY		0xA5
 
 #define AT91_RSTC_CR_PROCRST	0x00000001
 #define AT91_RSTC_CR_PERRST	0x00000004
include/configs/at91sam9260ek.h +1 -0
index 73917b0..53bef35 100644
@@ -177,6 +177,7 @@
 #define CONFIG_SYS_NO_FLASH			1
 
 /* Ethernet */
+#define CONFIG_MACB_SEARCH_PHY
 #define CONFIG_MACB			1
 #define CONFIG_RMII			1
 #define CONFIG_NET_RETRY_COUNT		20
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 arch-at91: Gets ethernet working on at91sam9g20 board

Dear John de la Garza,

this is a pure resent of [1]. Please read [2] and especially [3] on sending updated patches.

Quoted 11 lines · John de la Garza
Signed-off-by John de la Garza <[email protected]>
---
 arch/arm/include/asm/arch-at91/at91_rstc.h |    2 +-
 include/configs/at91sam9260ek.h            |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
arch/arm/include/asm/arch-at91/at91_rstc.h +0 -0
index a942342..59be96b 100644

arch/arm/include/asm/arch-at91/at91_rstc.h typedef struct at91_rstc { · line 28

Quoted 5 lines
arch/arm/include/asm/arch-at91/at91_rstc.h +1 -1
@@ -25,7 +25,7 @@ typedef struct at91_rstc {
 
 #endif /* __ASSEMBLY__ */
 
-#define AT91_RSTC_KEY		0xA5000000
+#define AT91_RSTC_KEY		0xA5

I have to NAK this again, you failed to respond on [4]. I may be wrong, but then please elaborate your change in detail.

Best regards

Andreas Bie?mann

[1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/180060
[2] http://www.denx.de/wiki/U-Boot/Patches
[3]
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
[4] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/180063

#2 lore raw

PATCH 1/1 arch-at91: Gets ethernet working on at91sam9g20 board

In reply to John de la Garza
Quoted 2 lines · John de la Garza
Signed-off-by John de la Garza <[email protected]>

Assuming that you fix something which isn't obvious, the commit message is incredibly short (it's empty).

virtually yours
Gerhard Sittig

Signature · 3 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de