usb: dwc3: gadget: remove known conditions

PATCH New Dan Carpenter 1 participant 1 message Mar 7, 2014

Subsystems (3)

USB Kernel janitors DesignWare USB3 DRD IP driver

lore

Share & tools

lore

Dan Carpenter

author

2014-03-07 11:20 UTC #0 lore raw

PATCH 2/2 usb: dwc3: gadget: remove known conditions

We know what "value" is and it upsets static checkers that we appear to have doubts about it.

Signed-off-by Dan Carpenter <[email protected]>

drivers/usb/dwc3/gadget.c +2 -4

index 95b9eae05617..a7df8120cf82 100644
@@ -1233,8 +1233,7 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value)
 		ret = dwc3_send_gadget_ep_cmd(dwc, dep->number,
 			DWC3_DEPCMD_SETSTALL, &params);
 		if (ret)
-			dev_err(dwc->dev, "failed to %s STALL on %s\n",
-					value ? "set" : "clear",
+			dev_err(dwc->dev, "failed to set STALL on %s\n",
 					dep->name);
 		else
 			dep->flags |= DWC3_EP_STALL;

@@ -1242,8 +1241,7 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int value)
 		ret = dwc3_send_gadget_ep_cmd(dwc, dep->number,
 			DWC3_DEPCMD_CLEARSTALL, &params);
 		if (ret)
-			dev_err(dwc->dev, "failed to %s STALL on %s\n",
-					value ? "set" : "clear",
+			dev_err(dwc->dev, "failed to clear STALL on %s\n",
 					dep->name);
 		else
 			dep->flags &= ~(DWC3_EP_STALL | DWC3_EP_WEDGE);