Skip to contentSkip to conversation

mfd: Fix cs5535 dependencies

PATCH Superseded Jean Delvare 3 participants 5 messages Mar 7, 2014 – Mar 10, 2014 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: Fix cs5535 dependencies

As far as I know, the CS5535 and CS5536 chipsets are companions of the Geode series of processors, which are 32-bit only. So the CS5535 drivers are not needed on x86-64, except for build testing purpose.

This aligns the dependencies to what FB_GEODE already uses.

Cc Samuel Ortiz <[email protected]>
Cc Lee Jones <[email protected]>
---
 drivers/mfd/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/Kconfig +1 -1
@@ -13,7 +13,7 @@ config MFD_CORE
 config MFD_CS5535
 	tristate "AMD CS5535 and CS5536 southbridge core functions"
 	select MFD_CORE
-	depends on PCI && X86
+	depends on PCI && (X86_32 || (X86 && COMPILE_TEST))
 	---help---
 	  This is the core driver for CS5535/CS5536 MFD functions.  This is
           necessary for using the board's GPIO and MFGPT functionality.
Signature · 2 lines
Jean Delvare
SUSE L3 Support
#1 lore raw
Quoted 7 lines · On Fri, 7 Mar 2014 22:00:51 +0100 Jean Delvare <[email protected]> wrote:

As far as I know, the CS5535 and CS5536 chipsets are companions of the Geode series of processors, which are 32-bit only. So the CS5535 drivers are not needed on x86-64, except for build testing purpose.

This aligns the dependencies to what FB_GEODE already uses.

This looks correct to me. Also true for the ATA driver and a few others plus for the CS5510 and 5520.

Alan

#2 lore raw
Quoted 6 lines
Quoted 4 lines · Jean Delvare

As far as I know, the CS5535 and CS5536 chipsets are companions of the Geode series of processors, which are 32-bit only. So the CS5535 drivers are not needed on x86-64, except for build testing purpose.

Quoted 6 lines
Quoted 3 lines

This aligns the dependencies to what FB_GEODE already uses.

This looks correct to me. Also true for the ATA driver and a few others plus for the CS5510 and 5520.

Is that an Ack Alan?

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#3 lore raw
In reply to One Thousand Gnomes
Quoted 7 lines · One Thousand Gnomes
Quoted 4 lines · On Fri, 7 Mar 2014 22:00:51 +0100 Jean Delvare <[email protected]> wrote:

As far as I know, the CS5535 and CS5536 chipsets are companions of the Geode series of processors, which are 32-bit only. So the CS5535 drivers are not needed on x86-64, except for build testing purpose.

Quoted 6 lines
Quoted 3 lines

This aligns the dependencies to what FB_GEODE already uses.

This looks correct to me. Also true for the ATA driver and a few others plus for the CS5510 and 5520.

And probably CONFIG_GEODE_WDT and CONFIG_SND_CS5535AUDIO as well?

Signature · 2 lines
Jean Delvare
SUSE L3 Support
#4 lore raw
Quoted 8 lines · Jean Delvare
Quoted 7 lines · One Thousand Gnomes
Quoted 4 lines · On Fri, 7 Mar 2014 22:00:51 +0100 Jean Delvare <[email protected]> wrote:

As far as I know, the CS5535 and CS5536 chipsets are companions of the Geode series of processors, which are 32-bit only. So the CS5535 drivers are not needed on x86-64, except for build testing purpose.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

This aligns the dependencies to what FB_GEODE already uses.

This looks correct to me. Also true for the ATA driver and a few others plus for the CS5510 and 5520.

And probably CONFIG_GEODE_WDT and CONFIG_SND_CS5535AUDIO as well?

... and CONFIG_PATA_CS5530?

Signature · 2 lines
Jean Delvare
SUSE L3 Support