Skip to contentSkip to conversation

fs: remove now stale label in anon_inode_init()

DISCUSSION Dave Jones 1 participant 1 message Mar 26, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw
Quoted 24 lines · Linux Kernel
Gitweb:     http://git.kernel.org/linus/;a=commit;h=fce7fc79c8f7188dfc5eafa1b937bcc3c5a4c2f5
Commit:     fce7fc79c8f7188dfc5eafa1b937bcc3c5a4c2f5
Parent:     d6f2589ad561aa5fa39f347eca6942668b7560a1
Author:     Linus Torvalds <[email protected]>
AuthorDate: Tue Mar 25 17:43:34 2014 -0700
Committer:  Linus Torvalds <[email protected]>
CommitDate: Tue Mar 25 17:43:34 2014 -0700

fs: remove now stale label in anon_inode_init()

The previous commit removed the register_filesystem() call and the associated error handling, but left the label for the error path that no longer exists. Remove that too.

---
 fs/anon_inodes.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
fs/anon_inodes.c +0 -0
index 4b4543b..42fcc46 100644

fs/anon_inodes.c static int __init anon_inode_init(void) · line 189

Quoted 5 lines
fs/anon_inodes.c +0 -1
@@ -186,7 +186,6 @@ static int __init anon_inode_init(void)
 
 err_unregister_filesystem:
 	unregister_filesystem(&anon_inode_fs_type);
-err_exit:
 	panic(KERN_ERR "anon_inode_init() failed (%d)\n", error);

If we're about to panic, is there any point in doing the unregister ? Looks like that function could just be..

        anon_inode_mnt = kern_mount(&anon_inode_fs_type);
        if (IS_ERR(anon_inode_mnt)) { 
                error = PTR_ERR(anon_inode_mnt);
                panic(KERN_ERR "anon_inode_init() failed (%d)\n", error);
        }       
        return 0;