Skip to contentSkip to conversation

Bug#742779: coccinelle introduces spurious whitespace changes

Cocci Eugeniy Meshcheryakov 2 participants 2 messages Mar 28, 2014 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

forwarded 742779 cocci at systeme.lip6.fr
thanks

Hello,

I've got the following bug report from a Debian user. It can be easily reproduced with RC20. Note that there is no space before equals signs in the generated patch.

Regards,
Eugeniy Meshcheryakov

27 ??????? 2014 ? 12:37 +0100 Justus Winter ???????(-??):

Quoted 92 lines

Package: coccinelle
Version: 1.0.0~rc20.deb-1
Severity: normal

Dear Maintainer,

coccinelle recently (since I upgraded to jessie I guess) began to introduce spurious whitespace changes for a certain semantic patch. I made a minimal test case:

% tail test.*
==> test.c <==
int main () {
int a = 4;
a = 2;
return a;
}

==> test.cocci <==
@@
@@
+ char *f = "%lu";

main (...) {
...
}

Curiously, the string %lu seems to trigger this. Bad, e.g. the current sid version:

% spatch --version
spatch version 1.0.0-rc20 with Python support and with PCRE support % spatch --sp-file test.cocci test.c
init_defs_builtins: /usr/share/coccinelle/standard.h
HANDLING: test.c
diff =

tmp/cocci-output-14372-7762e6-test.c renamed from test.c +4 -3
@@ -1,5 +1,6 @@
-int main () {
-  int a = 4;
-  a = 2;
+char *f= "%lu";
+int main() {
+  int a= 4;
+  a= 2;
   return a;
 }

Good, e.g. the version from wheezy:

% spatch --version
spatch version 1.0.0-rc12 with Python support and with PCRE support % spatch --sp-file test.cocci test.c
init_defs_builtins: /usr/share/coccinelle/standard.h
HANDLING: test.c
diff =

tmp/cocci-output-17254-5327d1-test.c renamed from test.c +1 -0
@@ -1,3 +1,4 @@
+char *f = "%lu";
 int main () {
   int a = 4;
   a = 2;

Thanks for your attention :)

-- System Information:
Distributor ID: Debian
Description: Debian GNU/Linux testing (jessie)
Release: testing
Codename: jessie
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages coccinelle depends on:

ii  libc6                                   2.18-4
ii  libpcre-ocaml [libpcre-ocaml-36gi0]     7.0.4-1
ii  libpcre3                                1:8.31-2
ii  libpycaml-ocaml                         0.82-14+b3
ii  libpython2.7                            2.7.6-7
ii  ocaml-base-nox [ocaml-base-nox-4.01.0]  4.01.0-3
ii  ocaml-findlib                           1.4-2
ii  python-glade2                           2.24.0-3+b1
ii  python-gobject                          3.10.2-2
ii  python-gtk2                             2.24.0-3+b1
pn  python:any                              <none>
Quoted 8 lines

coccinelle recommends no packages.

Versions of packages coccinelle suggests:

pn  coccinelle-doc     <none>
pn  vim-addon-manager  <none>

-- no debconf information

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20140328/ed623730/attachment.asc>

#2 lore raw

Thanks for forwarding the problem. I know where it is, and will try to fix it shortly.

julia

Quoted 114 lines · Eugeniy Meshcheryakov

forwarded 742779 cocci at systeme.lip6.fr
thanks

Hello,

I've got the following bug report from a Debian user. It can be easily reproduced with RC20. Note that there is no space before equals signs in the generated patch.

Regards,
Eugeniy Meshcheryakov

27 ??????? 2014 ? 12:37 +0100 Justus Winter ???????(-??):

Quoted 100 lines

Package: coccinelle
Version: 1.0.0~rc20.deb-1
Severity: normal

Dear Maintainer,

coccinelle recently (since I upgraded to jessie I guess) began to introduce spurious whitespace changes for a certain semantic patch. I made a minimal test case:

% tail test.*
==> test.c <==
int main () {
int a = 4;
a = 2;
return a;
}

==> test.cocci <==
@@
@@
+ char *f = "%lu";

main (...) {
...
}

Curiously, the string %lu seems to trigger this. Bad, e.g. the current sid version:

% spatch --version
spatch version 1.0.0-rc20 with Python support and with PCRE support % spatch --sp-file test.cocci test.c
init_defs_builtins: /usr/share/coccinelle/standard.h
HANDLING: test.c
diff =

tmp/cocci-output-14372-7762e6-test.c renamed from test.c +4 -3
@@ -1,5 +1,6 @@
-int main () {
-  int a = 4;
-  a = 2;
+char *f= "%lu";
+int main() {
+  int a= 4;
+  a= 2;
   return a;
 }

Good, e.g. the version from wheezy:

% spatch --version
spatch version 1.0.0-rc12 with Python support and with PCRE support % spatch --sp-file test.cocci test.c
init_defs_builtins: /usr/share/coccinelle/standard.h
HANDLING: test.c
diff =

tmp/cocci-output-17254-5327d1-test.c renamed from test.c +1 -0
@@ -1,3 +1,4 @@
+char *f = "%lu";
 int main () {
   int a = 4;
   a = 2;

Thanks for your attention :)

-- System Information:
Distributor ID: Debian
Description: Debian GNU/Linux testing (jessie)
Release: testing
Codename: jessie
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages coccinelle depends on:

ii  libc6                                   2.18-4
ii  libpcre-ocaml [libpcre-ocaml-36gi0]     7.0.4-1
ii  libpcre3                                1:8.31-2
ii  libpycaml-ocaml                         0.82-14+b3
ii  libpython2.7                            2.7.6-7
ii  ocaml-base-nox [ocaml-base-nox-4.01.0]  4.01.0-3
ii  ocaml-findlib                           1.4-2
ii  python-glade2                           2.24.0-3+b1
ii  python-gobject                          3.10.2-2
ii  python-gtk2                             2.24.0-3+b1
pn  python:any                              <none>

coccinelle recommends no packages.

Versions of packages coccinelle suggests:

pn  coccinelle-doc     <none>
pn  vim-addon-manager  <none>

-- no debconf information