Skip to contentSkip to conversation

rsi: rsi_91x: misleading debug printk

PATCH In review Dan Carpenter 2 participants 2 messages Mar 28, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rsi: rsi_91x: misleading debug printk

There is a missing set of curly braces here so the debug output says "Probe confirm received" unintentionally.

drivers/net/wireless/rsi/rsi_91x_mgmt.c +2 -1
index ef37d4b..2361a68 100644
@@ -1292,10 +1292,11 @@ int rsi_mgmt_pkt_recv(struct rsi_common *common, u8 *msg)
 			return -EINVAL;
 		}
 	} else if (msg_type = TX_STATUS_IND) {
-		if (msg[15] = PROBEREQ_CONFIRM)
+		if (msg[15] = PROBEREQ_CONFIRM) {
 			common->mgmt_q_block = false;
 			rsi_dbg(FSM_ZONE, "%s: Probe confirm received\n",
 				__func__);
+		}
 	} else {
 		return rsi_mgmt_pkt_to_core(common, msg, msg_len, msg_type);
 	}
#1 lore raw

;-)

goto fail;
goto fail;

Thanks, Dan!

Quoted 23 lines · Dan Carpenter

There is a missing set of curly braces here so the debug output says "Probe confirm received" unintentionally.

drivers/net/wireless/rsi/rsi_91x_mgmt.c +2 -1
index ef37d4b..2361a68 100644
@@ -1292,10 +1292,11 @@ int rsi_mgmt_pkt_recv(struct rsi_common *common, u8 *msg)
 			return -EINVAL;
 		}
 	} else if (msg_type = TX_STATUS_IND) {
-		if (msg[15] = PROBEREQ_CONFIRM)
+		if (msg[15] = PROBEREQ_CONFIRM) {
 			common->mgmt_q_block = false;
 			rsi_dbg(FSM_ZONE, "%s: Probe confirm received\n",
 				__func__);
+		}
 	} else {
 		return rsi_mgmt_pkt_to_core(common, msg, msg_len, msg_type);
 	}
Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.