Skip to contentSkip to conversation

rtl8180: fix enabled interrupt mask for rtl8187se

PATCH Superseded Andrea Merello 1 participant 1 message Apr 4, 2014 1 message not in the archive Networking drivers (wireless)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20140403054254.GA18196@localhost

#1 lore raw

PATCH 2/4 rtl8180: fix enabled interrupt mask for rtl8187se

When preparing the bitfield to write to HW register, the high-priority queue error interrupt bit is set two times, and the beacon queue TX-OK interrupt is not enabled.

Currently this have no functional impact because the high-priority queue is not used at all, and the beacon queue is not used yet.

This patch removes high-priority queue bits and it adds the beacon queue missing bit.
It removes also the management queue bits because it is not used.

This was found by static code analyzer.

---
 drivers/net/wireless/rtl818x/rtl8180/dev.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/wireless/rtl818x/rtl8180/dev.c +2 -3
index 98d8256f..cb8275f 100644
@@ -683,9 +683,8 @@ static void rtl8180_int_enable(struct ieee80211_hw *dev)
 	struct rtl8180_priv *priv = dev->priv;
 
 	if (priv->chip_family == RTL818X_CHIP_FAMILY_RTL8187SE) {
-		rtl818x_iowrite32(priv, &priv->map->IMR, IMR_TMGDOK |
-			  IMR_TBDER | IMR_THPDER |
-			  IMR_THPDER | IMR_THPDOK |
+		rtl818x_iowrite32(priv, &priv->map->IMR,
+			  IMR_TBDER | IMR_TBDOK |
 			  IMR_TVODER | IMR_TVODOK |
 			  IMR_TVIDER | IMR_TVIDOK |
 			  IMR_TBEDER | IMR_TBEDOK |
Signature · 1 line
1.8.3.2