Skip to contentSkip to conversation

i2c: qup: off by ones in qup_i2c_probe()

PATCH Applied Dan Carpenter 2 participants 2 messages Apr 3, 2014

Subsystems (3)
Arm Qualcomm mailing list Kernel janitors I2C subsystem host drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 i2c: qup: off by ones in qup_i2c_probe()

These should ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()".

Fixes 10c5a8425968 ('i2c: qup: New bus driver for the Qualcomm QUP I2C controller')
Signed-off-by Dan Carpenter <[email protected]>
drivers/i2c/busses/i2c-qup.c +2 -2
index c9d5f78..ee40980 100644
@@ -633,12 +633,12 @@ static int qup_i2c_probe(struct platform_device *pdev)
 	 * associated with each byte written/received
 	 */
 	size = QUP_OUTPUT_BLOCK_SIZE(io_mode);
-	if (size > ARRAY_SIZE(blk_sizes))
+	if (size >= ARRAY_SIZE(blk_sizes))
 		return -EIO;
 	qup->out_blk_sz = blk_sizes[size] / 2;
 
 	size = QUP_INPUT_BLOCK_SIZE(io_mode);
-	if (size > ARRAY_SIZE(blk_sizes))
+	if (size >= ARRAY_SIZE(blk_sizes))
 		return -EIO;
 	qup->in_blk_sz = blk_sizes[size] / 2;
Applied
#1 lore raw
Quoted 4 lines · Dan Carpenter

These should ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()".

Fixes 10c5a8425968 ('i2c: qup: New bus driver for the Qualcomm QUP I2C controller')
Signed-off-by Dan Carpenter <[email protected]>

Ah, right. I misinterpreted the smatch message, thought it was a false positive :(

Applied to for-next, thanks!