generic: fix check for zero range support in generic/009
PATCH 1/1 generic: fix check for zero range support in generic/009
Generic/001 fails when run on a file system that does not support byte range zeroing. For example, an EOPNOTSUPP failure occurs when the test is run on a pre-3.15 extent-mapped file system. The code in the test intended to prevent this contains an apparent typo that results in a check for fallocate() rather than zero range support.
--- tests/generic/009 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/009 +1 -1
@@ -44,7 +44,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 # real QA test starts here _supported_os Linux -_require_xfs_io_falloc "fzero" +_require_xfs_io_command "fzero" testfile=$TEST_DIR/009.$$
Signature · 1 line
1.8.3.2
Quoted 7 lines · Eric Whitney
Generic/001 fails when run on a file system that does not support byte range zeroing. For example, an EOPNOTSUPP failure occurs when the test is run on a pre-3.15 extent-mapped file system. The code in the test intended to prevent this contains an apparent typo that results in a check for
fallocate()rather than zero range support.Signed-off-by Eric Whitney <[email protected]>
LGTM.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 16 lines · Eric Whitney
Generic/001 fails when run on a file system that does not support byte range zeroing. For example, an EOPNOTSUPP failure occurs when the test is run on a pre-3.15 extent-mapped file system. The code in the test intended to prevent this contains an apparent typo that results in a check for
fallocate()rather than zero range support.Signed-off-by Eric Whitney <[email protected]>--- tests/generic/009 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/009 +0
-0
tests/generic/009 trap "_cleanup ; exit \$status" 0 1 2 3 15 · line 47
Quoted 5 lines
tests/generic/009 +1
-1@@ -44,7 +44,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15 # real QA test starts here _supported_os Linux -_require_xfs_io_falloc "fzero" +_require_xfs_io_command "fzero"
There should be a helper in common/rc for this. i.e. _require_xfs_io_fzero. There's helpers for everything else. Can you add the helper and wire the tests up to it properly?
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
* Dave Chinner <[email protected]>:
Quoted 18 lines · Eric Whitney
Quoted 17 lines
Generic/001 fails when run on a file system that does not support byte range zeroing. For example, an EOPNOTSUPP failure occurs when the test is run on a pre-3.15 extent-mapped file system. The code in the test intended to prevent this contains an apparent typo that results in a check for
fallocate()rather than zero range support.Signed-off-by Eric Whitney <[email protected]>--- tests/generic/009 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/009 +0
-0@@ -44,7 +44,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15
Quoted 9 lines
tests/generic/009 trap "_cleanup ; exit \$status" 0 1 2 3 15 · line 47
Quoted 4 lines
tests/generic/009 +1
-1# real QA test starts here _supported_os Linux -_require_xfs_io_falloc "fzero" +_require_xfs_io_command "fzero"There should be a helper in common/rc for this. i.e.
_require_xfs_io_fzero. There's helpers for everything else. Can you add the helper and wire the tests up to it properly?
Sure. For naming consistency with the other related helper functions, it looks like we'd want to call this _require_xfs_io_falloc_zero(). I'm happy to change this if I'm mistaken. Patches on the way.
Thanks,
Eric
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs