Skip to contentSkip to conversation

staging: crypto: skein: depend upon CRYPTO

PATCH In review Jason Cooper 2 participants 2 messages Apr 25, 2014 – Apr 28, 2014 1 message not in the archive

Subsystems (2)
Staging Crypto API
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20140425151554.GB31117@localhost

Jason Cooper

author
#1 lore raw

PATCH 1/1 staging: crypto: skein: depend upon CRYPTO

Fengguang's randconfig kernel build tester discovered the following warnings:

warning: (CRYPTO_THREEFISH) selects CRYPTO_ALGAPI which has unmet direct dependencies (CRYPTO)
warning: (DM_VERITY && CRYPTO_SKEIN) selects CRYPTO_HASH which has unmet direct dependencies (CRYPTO)

Fix this in the Kconfig by depending on CRYPTO.

Reported-by Fengguang Wu <[email protected]>
Signed-off-by Jason Cooper <[email protected]>
---
 drivers/staging/skein/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/skein/Kconfig +2 -2
index 8f5a72a90ced..b9172bfcdc1b 100644
@@ -1,6 +1,6 @@
 config CRYPTO_SKEIN
 	bool "Skein digest algorithm"
-	depends on (X86 || UML_X86) && 64BIT
+	depends on (X86 || UML_X86) && 64BIT && CRYPTO
 	select CRYPTO_THREEFISH
 	select CRYPTO_HASH
 	help

@@ -17,7 +17,7 @@ config CRYPTO_SKEIN
 
 config CRYPTO_THREEFISH
 	bool "Threefish tweakable block cipher"
-	depends on (X86 || UML_X86) && 64BIT
+	depends on (X86 || UML_X86) && 64BIT && CRYPTO
 	select CRYPTO_ALGAPI
 	help
 	  Threefish cipher algorithm is the tweakable block cipher underneath
Signature · 1 line
1.9.2
Reviewed-by on v1 1/1
#2 lore raw
Quoted 11 lines · Jason Cooper

Fengguang's randconfig kernel build tester discovered the following warnings:

warning: (CRYPTO_THREEFISH) selects CRYPTO_ALGAPI which has unmet direct dependencies (CRYPTO) warning: (DM_VERITY && CRYPTO_SKEIN) selects CRYPTO_HASH which has unmet direct dependencies (CRYPTO)

Fix this in the Kconfig by depending on CRYPTO.

Reported-by Fengguang Wu <[email protected]>
Signed-off-by Jason Cooper <[email protected]>
Reviewed-by Marek Vasut <[email protected]>

Best regards,
Marek Vasut