staging/cxt1e1: sparse warning corrections
PATCH 1/1 staging/cxt1e1: sparse warning corrections
From: Sami Laine <[email protected]>
Corrected sparse static declaration warnings.
---
drivers/staging/cxt1e1/hwprobe.c +7 -7
@@ -40,10 +40,10 @@ struct net_device * __init c4_add_dev(hdw_info_t *, int, unsigned long, unsigned long, int, int); -struct s_hdw_info hdw_info[MAX_BOARDS ]; +static struct s_hdw_info hdw_info[MAX_BOARDS ]; -void __init +static void __init show_two (hdw_info_t *hi,int brdno) {ci_t *ci;
@@ -88,7 +88,7 @@ show_two(hdw_info_t *hi, int brdno) } -void __init +static void __init hdw_sn_get (hdw_info_t *hi,int brdno) {/* obtain hardware EEPROM information */
@@ -145,7 +145,7 @@ hdw_sn_get(hdw_info_t *hi, int brdno) } -void __init +static void __init prep_hdw_info (void ) {hdw_info_t *hi;
@@ -164,7 +164,7 @@ prep_hdw_info(void) } } -void +static void cleanup_ioremap (void ) {hdw_info_t *hi;
@@ -187,7 +187,7 @@ cleanup_ioremap(void) } -void +static void cleanup_devs (void ) {hdw_info_t *hi;
@@ -287,7 +287,7 @@ c4_hdw_init(struct pci_dev *pdev, int found)return 1 ; } -status_t __init +static status_t __init c4hw_attach_all (void ) {hdw_info_t *hi;
Hi,
2014-04-27 0:53 GMT+09:00 Sami Laine <[email protected]>:
Quoted 1 line
From: Sami Laine <[email protected]>
do not include this line on your patch. it is not necessary.
Quoted 10 lines
Corrected sparse static declaration warnings.
Signed-off-by Sami Laine <[email protected]>---
drivers/staging/cxt1e1/hwprobe.c +0
-0
drivers/staging/cxt1e1/hwprobe.c struct net_device * __init c4_add_dev(hdw_info_t *, int, unsigned long, · line 43
Quoted 5 lines
drivers/staging/cxt1e1/hwprobe.c +1
-1@@ -40,10 +40,10 @@ struct net_device * __init c4_add_dev(hdw_info_t *, int, unsigned long, unsigned long, int, int); -struct s_hdw_info hdw_info[MAX_BOARDS ]; +static struct s_hdw_info hdw_info[MAX_BOARDS ];
hdw_info is used in other files with "extern".
Quoted 8 lines
drivers/staging/cxt1e1/hwprobe.c +1
-1-void __init +static void __init show_two (hdw_info_t *hi,int brdno) {ci_t *ci;
drivers/staging/cxt1e1/hwprobe.c show_two(hdw_info_t *hi, int brdno) · line 92
Quoted 6 lines
drivers/staging/cxt1e1/hwprobe.c +1
-1@@ -88,7 +88,7 @@ show_two(hdw_info_t *hi, int brdno) } -void __init +static void __init hdw_sn_get (hdw_info_t *hi,int brdno)
This function is used in "linux.c"
Quoted 12 lines
drivers/staging/cxt1e1/hwprobe.c +1
-1{/* obtain hardware EEPROM information */ @@ -145,7 +145,7 @@ hdw_sn_get(hdw_info_t *hi, int brdno) } -void __init +static void __init prep_hdw_info (void ) {hdw_info_t *hi;
drivers/staging/cxt1e1/hwprobe.c prep_hdw_info(void) · line 168
Quoted 6 lines
drivers/staging/cxt1e1/hwprobe.c +1
-1@@ -164,7 +164,7 @@ prep_hdw_info(void) } } -void +static void cleanup_ioremap (void )
This function is used in "linux.c"
drivers/staging/cxt1e1/hwprobe.c cleanup_ioremap(void) · line 192
Quoted 10 lines
drivers/staging/cxt1e1/hwprobe.c +1
-1{hdw_info_t *hi;@@ -187,7 +187,7 @@ cleanup_ioremap(void) } -void +static void cleanup_devs (void )
This function is used in "linux.c"
drivers/staging/cxt1e1/hwprobe.c c4_hdw_init(struct pci_dev *pdev, int found) · line 291
Quoted 9 lines
drivers/staging/cxt1e1/hwprobe.c +0
-0{hdw_info_t *hi;drivers/staging/cxt1e1/hwprobe.c +1
-1@@ -287,7 +287,7 @@ c4_hdw_init(struct pci_dev *pdev, int found)return 1 ; } -status_t __init +static status_t __init c4hw_attach_all (void )
This function is used in "linux.c"
drivers/staging/cxt1e1/hwprobe.c c4_hdw_init(struct pci_dev *pdev, int found) · line 293
Quoted 2 lines
drivers/staging/cxt1e1/hwprobe.c +0
-0{hdw_info_t *hi;
And when you send a patch for this, please check maintainers with " ./scripts/get_maintainer.pl".
In case of this patch, my email is in CC list. :-)
Regards,
Daeseok Youn.