drm-intel-next
Hi Dave,
drm-intel-next-2014-04-16:
- vlv infoframe fixes from Jesse
- dsi/mipi fixes from Shobhit
- gen8 pageflip fixes for LRI/SRM from Damien
- cmd parser fixes from Brad Volkin
- some prep patches for CHV, DRRS, ...
- and tons of little things all over
drm-intel-next-2014-04-04:
- cmd parser for gen7 but only in enforcing and not yet granting mode - the batch copying stuff is still missing. Also performance is a bit ... rough (Brad Volkin + OACONTROL fix from Ken).
- deprecate UMS harder (i.e. CONFIG_BROKEN)
- interrupt rework from Paulo Zanoni
- runtime PM support for bdw and snb, again from Paulo
- a pile of refactorings from various people all over the place to prep for new stuff (irq reworks, power domain polish, ...)
drm-intel-next-2014-04-04:
- cmd parser for gen7 but only in enforcing and not yet granting mode - the batch copying stuff is still missing. Also performance is a bit ... rough (Brad Volkin + OACONTROL fix from Ken).
- deprecate UMS harder (i.e. CONFIG_BROKEN)
- interrupt rework from Paulo Zanoni
- runtime PM support for bdw and snb, again from Paulo
- a pile of refactorings from various people all over the place to prep for new stuff (irq reworks, power domain polish, ...)
As discussed on irc this contains a (not yet fully tuned and also not yet in granting mode) cmd parser for gen7. Performance is still a bit rough, but not quite as bad as originally feared (Ken later on discovered that he also changed something in his glamour setup which made things worse). If it doesn't get better (and ofc if we don't get all the missing bits in for granting mode) I'll disable it before 3.16 again. But I want to give this beast as much testing as possible for now to avoid ugly regressions once we switch it on.
Also please don't use the autogenerate merge commit since that'll miss the stuff from the 1st drm-intel-next tag.
If I read the merges in -nightly correctly there's a bit a conflict in i915_gem_context.c. I can provide an example merge if you want (or otherwise just peak at linux-next or drm-intel-nightly).
Cheers, Daniel
The following changes since commit c39b06951f1dc2e384650288676c5b7dcc0ec92c:
DRM: armada: fix corruption while loading cursors (2014-04-08 10:51:03 +1000)
are available in the git repository at:
git://anongit.freedesktop.org/drm-intel tags/drm-intel-next-2014-04-16
for you to fetch changes up to c79057922ed6c2c6df1214e6ab4414fea1b23db2:
drm/i915: Remove vblank wait from haswell_write_eld (2014-04-16 18:52:47 +0200)
----------------------------------------------------------------
- vlv infoframe fixes from Jesse
- dsi/mipi fixes from Shobhit
- gen8 pageflip fixes for LRI/SRM from Damien
- cmd parser fixes from Brad Volkin
- some prep patches for CHV, DRRS, ...
- and tons of little things all over
----------------------------------------------------------------
Akash Goel (2):
drm/i915: Enabling the TLB invalidate bit in GFX Mode register drm/i915/vlv:Implement the WA 'WaDisable_RenderCache_OperationalFlush'
Ben Widawsky (10):
drm/i915: Split out GTT specific header file drm/i915: Allow full PPGTT with param override drm/i915/bdw: Set initial rps freq to RP1 drm/i915/bdw: Extract rp_state_caps logic drm/i915/bdw: RPS frequency bits are the same as HSW drm/i915/bdw: Expand FADD to 64bit drm/i915: Invariably invalidate before ctx switch drm/i915: Unref context on failed eb_create drm/i915: Dump the whole context object. drm/i915/bdw: Add 42ms delay for IPS disable
Brad Volkin (15):
drm/i915: Initial command parser table definitions drm/i915: Reject privileged commands
drm/i915: Allow some privileged commands from master drm/i915: Add register whitelists for mesa
drm/i915: Add register whitelist for DRM master drm/i915: Enable register whitelist checks
drm/i915: Reject commands that explicitly generate interrupts drm/i915: Enable PPGTT command parser checks drm/i915: Reject commands that would store to global HWS page drm/i915: Add a CMD_PARSER_VERSION getparam
drm/i915: Enable command parsing by default
drm/i915: BUG_ON() when cmd/reg tables are not sorted drm/i915: Refactor cmd parser checks into a function drm/i915: Track OACONTROL register enable/disable during parsing drm/i915: Add more registers to the whitelist for mesa
Chris Wilson (4):
drm/i915: Rename GFX_TLB_INVALIDATE_ALWAYS
drm/i915: Add PM interrupt details and RPS thresholds to debugfs drm/i915: Move all ring resets before setting the HWS page drm/i915: dma_buf_vunmap is presumed not to fail, don't let it
Christoph Jaeger (1):
drm/i915: drop __FUNCTION__ as argument to DRM_DEBUG_KMS
Damien Lespiau (10):
drm/i915: Don't store the max cursor width/height in the crtc drm/i915: Hide vlv_force_wake_{get, put}() in intel_uncore.c drm/i915: Hide the per forcewake-engine register ranges drm/i915: Use a macro to express the range of valid gens for reg_read drm/i915: Protect the argument expansion in LRI and SRM macros drm/i915/bdw: Provide a gen8 version of SRM
drm/i915/bdw: Use the GEN8 SRM when qeueing a flip drm/i915: Rename GEN8_PIPE_FLIP_DONE to PRIMARY_FLIP_DONE drm/i915: Remove misleading debug message
drm/i915: Remove spurious semicolons
Daniel Vetter (10):
drm/i915: Add FIXME for bdw semaphore detection in hancheck drm/i915: make semaphore signaller detection more robust drm/i915: Deprecate UMS harder
drm/i915: Add debug module option for VTd validation drm/i915: dmesg output for VT-d testing
Merge remote-tracking branch 'airlied/drm-next' into HEAD Revert "drm/i915: fix infinite loop at gen6_update_ring_freq" drm/i915: Don't set the 8to6 dither flag when not scaling drm/i915: Don't vblank wait on ilk-ivb after pipe enable drm/i915: Remove vblank wait from haswell_write_eld
Deepak S (1):
drm/i915: Match debugfs interface name to new RPS naming
Egbert Eich (1):
drm/i915/SDVO: For sysfs link put directory and target in correct order
Imre Deak (2):
drm/i915: vlv: cache current CD clock rate
drm/i915: vlv: get power domain for eDP vdd
Jani Nikula (2):
drm/i915: drop the typedef for drm_i915_private_t drm/i915: fix command parser debug print format mismatches
Jesse Barnes (5):
drm/i915: warn when a vblank wait times out drm/i915/vlv: write the port field in the per-pipe DIP control reg drm/i915/vlv: disable AVI infoframe emission when writing infoframes drm/i915: enable HDMI mode on VLV when an HDMI sink is detected drm/i915: move infoframe setting to after pll enable v3
Kenneth Graunke (1):
drm/i915: Add OACONTROL to the command parser register whitelist.
Mika Kuoppala (1):
drm/i915: add flags to i915_ring_stop
Paulo Zanoni (27):
drm/i915: add GEN5_IRQ_INIT macro
drm/i915: also use GEN5_IRQ_INIT with south display interrupts drm/i915: use GEN8_IRQ_INIT on GEN5
drm/i915: add GEN5_IRQ_FINI
drm/i915: don't forget to uninstall the PM IRQs drm/i915: properly clear IIR at irq_uninstall on Gen5+ drm/i915: add GEN5_IRQ_INIT
drm/i915: check if IIR is still zero at postinstall on Gen5+ drm/i915: fix SERR_INT init/reset code
drm/i915: fix GEN7_ERR_INT init/reset code drm/i915: fix open coded gen5_gt_irq_preinstall drm/i915: extract ibx_irq_uninstall
drm/i915: call ibx_irq_uninstall from gen8_irq_uninstall drm/i915: enable SDEIER later
drm/i915: remove ibx_irq_uninstall
drm/i915: add missing intel_hpd_irq_uninstall drm/i915: add ironlake_irq_reset
drm/i915: add gen8_irq_reset
drm/i915: only enable HWSTAM interrupts on postinstall on ILK+ drm/i915: kill dev_priv->pm.regsave
drm/i915: add gen-specific runtime suspend/resume functions drm/i915: add SNB runtime PM support
drm/i915: remove HAS_PC8 check
drm/i915: BDW needs D_COMP writes through MCHBAR drm/i915: add BDW runtime PM support
drm/i915: only check for irqs_disabled when disabling LCPLL drm/i915: fix infinite loop at gen6_update_ring_freq
Pradeep Bhat (3):
drm/i915: Adding VBT fields to support eDP DRRS feature drm/i915: Parse EDID probed modes for DRRS support drm/i915: Add support for DRRS to switch RR
Rafael Barbalho (1):
drm/i915: Fix framecount offset
Shobhit Kumar (9):
drm/i915: Program Rcomp and band gap reset everytime we resume from power gate drm/i915: Enable MIPI port before the plane and pipe enable drm/i915: Disable DPOunit clock gating
drm/i915: Parameterize the Clockstop and escape_clk_div drm/i915: Panel commands can be sent only when clock is in LP11 drm/i915: Send DPI command explicitely in LP mode
drm/i915: Enable RANDOM resolution support for MIPI panels drm/i915: Add parsing support for new MIPI blocks in VBT drm/i915: Code cleanup patch to fix checkpatch errors
Ville Syrjälä (17):
drm/i915: Kill crtc->plane checks from the primary plane update hooks drm/i915: Split dp post_disable hooks
drm/i915: Refactor gmch hpd irq handling
drm: Make drm_clflush_virt_range() void*
drm/i915: Implement WaProgramMiArbOnOffAroundMiSetContext:bdw drm/i915: Fix debugfs PDP register dump
drm/i915: Move DP M/N setup from update_pll to mode_set for gmch platforms drm/i915: Warn when DPIO read returns 0xffffffff
drm/i915: Provide a bit more info when pipestat bits are wrong drm/i915: Make contexts non-snooped on non-LLC platforms drm/i915: Don't read sprite LP2+ registers on ILK/SNB
drm/i915: Add some more tracked state to intel_pipe_wm
drm/i915: Skip watermark merging for inactive pipes
drm/i916: Refactor WM register maximums
drm/i915/chv: IS_BROADWELL() should not be true for Cherryview drm/i915/chv: Add IS_CHERRYVIEW() macro
drm/i915: Disable/enable planes as the first/last thing during modeset on ILK+
Zhenyu Wang (1):
drm/i915: Allow i915_pc8_status debug info on BDW
drivers/gpu/drm/drm_cache.c | 4 +- drivers/gpu/drm/i915/Kconfig | 2 +- drivers/gpu/drm/i915/dvo_ch7xxx.c | 2 +- drivers/gpu/drm/i915/dvo_ivch.c | 2 +- drivers/gpu/drm/i915/dvo_ns2501.c | 24 +- drivers/gpu/drm/i915/dvo_sil164.c | 2 +- drivers/gpu/drm/i915/dvo_tfp410.c | 2 +- drivers/gpu/drm/i915/i915_cmd_parser.c | 616 +++++++++++++++++++++++++---- drivers/gpu/drm/i915/i915_debugfs.c | 25 +- drivers/gpu/drm/i915/i915_dma.c | 3 + drivers/gpu/drm/i915/i915_drv.c | 53 ++- drivers/gpu/drm/i915/i915_drv.h | 265 +++---------- drivers/gpu/drm/i915/i915_gem.c | 5 +- drivers/gpu/drm/i915/i915_gem_context.c | 18 +- drivers/gpu/drm/i915/i915_gem_dmabuf.c | 6 +- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 3 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 75 +--- drivers/gpu/drm/i915/i915_gem_gtt.h | 283 +++++++++++++ drivers/gpu/drm/i915/i915_gpu_error.c | 23 +- drivers/gpu/drm/i915/i915_irq.c | 504 +++++++++++------------ drivers/gpu/drm/i915/i915_params.c | 8 +- drivers/gpu/drm/i915/i915_reg.h | 117 +++++- drivers/gpu/drm/i915/intel_bios.c | 242 +++++++++++- drivers/gpu/drm/i915/intel_bios.h | 60 +++ drivers/gpu/drm/i915/intel_display.c | 283 ++++++------- drivers/gpu/drm/i915/intel_dp.c | 197 ++++++++- drivers/gpu/drm/i915/intel_drv.h | 35 +- drivers/gpu/drm/i915/intel_dsi.c | 125 ++++-- drivers/gpu/drm/i915/intel_dsi.h | 4 +- drivers/gpu/drm/i915/intel_dsi_cmd.c | 4 +- drivers/gpu/drm/i915/intel_dsi_cmd.h | 5 +- drivers/gpu/drm/i915/intel_hdmi.c | 38 +- drivers/gpu/drm/i915/intel_lvds.c | 7 - drivers/gpu/drm/i915/intel_panel.c | 8 +- drivers/gpu/drm/i915/intel_pm.c | 219 ++++++---- drivers/gpu/drm/i915/intel_ringbuffer.c | 75 ++-- drivers/gpu/drm/i915/intel_ringbuffer.h | 5 +- drivers/gpu/drm/i915/intel_sdvo.c | 4 +- drivers/gpu/drm/i915/intel_sideband.c | 8 + drivers/gpu/drm/i915/intel_uncore.c | 24 +- include/drm/drmP.h | 2 +- include/uapi/drm/i915_drm.h | 1 + 42 files changed, 2354 insertions(+), 1034 deletions(-) create mode 100644 drivers/gpu/drm/i915/i915_gem_gtt.h
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Quoted 9 lines
As discussed on irc this contains a (not yet fully tuned and also not yet in granting mode) cmd parser for gen7. Performance is still a bit rough, but not quite as bad as originally feared (Ken later on discovered that he also changed something in his glamour setup which made things worse). If it doesn't get better (and ofc if we don't get all the missing bits in for granting mode) I'll disable it before 3.16 again. But I want to give this beast as much testing as possible for now to avoid ugly regressions once we switch it on.
Quoted 7 lines
Also please don't use the autogenerate merge commit since that'll miss the stuff from the 1st drm-intel-next tag.
If I read the merges in -nightly correctly there's a bit a conflict in
i915_gem_context.c. I can provide an example merge if you want (or otherwise just peak at linux-next or drm-intel-nightly).
Merged, but 32-bit still a thing,
CC [M] drivers/gpu/drm/i915/i915_cmd_parser.o
/ssd/git/drm-next/drivers/gpu/drm/i915/i915_cmd_parser.c: In function ‘i915_parse_cmds’:
/ssd/git/drm-next/drivers/gpu/drm/i915/i915_cmd_parser.c:919:4:
warning: format ‘%td’ expects argument of type ‘ptrdiff_t’, but argument 5 has type ‘long unsigned int’ [-Wformat=]
DRM_DEBUG_DRIVER("CMD: Command length exceeds batch length: 0x%08X
length=%u batchlen=%td\n",
^Dave.
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 9 lines · Dave Airlie
Merged, but 32-bit still a thing,
CC [M]
drivers/gpu/drm/i915/i915_cmd_parser.o
/ssd/git/drm-next/drivers/gpu/drm/i915/i915_cmd_parser.c: In function ‘i915_parse_cmds’:
/ssd/git/drm-next/drivers/gpu/drm/i915/i915_cmd_parser.c:919:4:
warning: format ‘%td’ expects argument of type ‘ptrdiff_t’, but argument 5 has type ‘long unsigned int’ [-Wformat=]
Quoted 3 lines
DRM_DEBUG_DRIVER("CMD: Command length exceeds batch length: 0x%08X
length=%u batchlen=%td\n",
^Oops, sorry about this. I've made a pretty decent mess here by applying two competing patches to fix the issue ;-) My -next queue has the revert for one again already, so should be addressed with the next pull request:
commit dcfce6cafbb1e2afb16792f2834d9924924c2228
Author: Jan Moskyto Matejka <[email protected]> Date: Mon Apr 28 15:03:23 2014 +0200
Revert "drm/i915: fix build warning on 32-bit (v2)"
Cheers, Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 19 lines · Daniel Vetter
Hi Dave,
drm-intel-next-2014-04-16:
- vlv infoframe fixes from Jesse
- dsi/mipi fixes from Shobhit
- gen8 pageflip fixes for LRI/SRM from Damien
- cmd parser fixes from Brad Volkin
- some prep patches for CHV, DRRS, ...
- and tons of little things all over
drm-intel-next-2014-04-04:
- cmd parser for gen7 but only in enforcing and not yet granting mode - the batch copying stuff is still missing. Also performance is a bit ... rough (Brad Volkin + OACONTROL fix from Ken).
- deprecate UMS harder (i.e.CONFIG_BROKEN)
- interrupt rework from Paulo Zanoni
- runtime PM support for bdw and snb, again from Paulo
- a pile of refactorings from various people all over the place to prep for new stuff (irq reworks, power domain polish, ...)
Quoted 10 lines
drm-intel-next-2014-04-04:
- cmd parser for gen7 but only in enforcing and not yet granting mode - the batch copying stuff is still missing. Also performance is a bit ... rough (Brad Volkin + OACONTROL fix from Ken).
- deprecate UMS harder (i.e.CONFIG_BROKEN)
- interrupt rework from Paulo Zanoni
- runtime PM support for bdw and snb, again from Paulo
- a pile of refactorings from various people all over the place to prep for new stuff (irq reworks, power domain polish, ...)
The patch below is a clear candidate for 3.15 as it fixes a regression introduced after 3.14
Quoted 2 lines
Egbert Eich (1):
drm/i915/SDVO: For sysfs link put directory and target in correct order
Without it I see
[ 2.603235] ------------[ cut here ]------------ [ 2.603371] WARNING: CPU: 0 PID: 1 at fs/sysfs/dir.c:486 sysfs_warn_dup+0x68/0x7a() [ 2.603605] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:02.0/i2c-7/i2c-7' [ 2.603841] Modules linked in: [ 2.603992] CPU: 0 PID: 1 Comm: swapper Not tainted 3.13.0-main-01064-gd978ef1 #131 [ 2.604232] Hardware name: /i915GMm-HFS, BIOS 6.00 PG 09/14/2005 [ 2.604367] 00000000 f6079c64 f6079c3c c055593e f6079c54 c012a6a9 c022bc73 f6366000 [ 2.604781] f6366000 f6367200 f6079c6c c012a6eb 00000009 f6079c64 c06f0720 f6079c80 [ 2.605194] f6079c90 c022bc73 c06f06d0 000001e6 c06f0720 f6366000 f6367200 f6371c00 [ 2.605606] Call Trace: [ 2.605736] [<c055593e>] dump_stack+0x16/0x18 [ 2.605871] [<c012a6a9>] warn_slowpath_common+0x5f/0x76 [ 2.606005] [<c022bc73>] ? sysfs_warn_dup+0x68/0x7a [ 2.606139] [<c012a6eb>] warn_slowpath_fmt+0x2b/0x2f [ 2.606273] [<c022bc73>] sysfs_warn_dup+0x68/0x7a [ 2.606407] [<c022bcaa>] sysfs_add_one+0x25/0x2c [ 2.606541] [<c022c567>] sysfs_do_create_link_sd.isra.2+0xc4/0x136 [ 2.606678] [<c022c5fd>] sysfs_create_link+0x24/0x2e [ 2.606814] [<c0405e55>] intel_sdvo_connector_init+0x82/0xa2 [ 2.606950] [<c0407ad4>] intel_sdvo_tv_init+0x81/0x1cf [ 2.607086] [<c0408a7b>] intel_sdvo_init+0x2ef/0x658 [ 2.607221] [<c039e331>] ? drm_ut_debug_printk+0x41/0x55 [ 2.607358] [<c03ed664>] intel_modeset_init+0xabd/0xdae [ 2.607494] [<c055e27a>] ? preempt_count_sub+0xa8/0xb5 [ 2.607630] [<c055ae44>] ? _raw_spin_unlock_irqrestore+0x44/0x56 [ 2.607768] [<c03cfec6>] ? i915_irq_postinstall+0xee/0xf8 [ 2.607903] [<c039c688>] ? drm_irq_install+0x155/0x1b5 [ 2.608046] [<c03d0fbf>] ? i965_irq_handler+0x480/0x480 [ 2.608181] [<c040c7b4>] i915_driver_load+0xa53/0xcc3 [ 2.608318] [<c039e8cb>] drm_dev_register+0xb8/0x11b [ 2.608452] [<c03a04d1>] drm_get_pci_dev+0xec/0x18a [ 2.608587] [<c03acd4a>] i915_pci_probe+0x3e/0x47 [ 2.608722] [<c030d636>] pci_device_probe+0x5c/0xa4 [ 2.608857] [<c0419fce>] driver_probe_device+0x83/0x17a [ 2.608991] [<c041a149>] __driver_attach+0x53/0x6f [ 2.609127] [<c0418b32>] bus_for_each_dev+0x58/0x67 [ 2.609261] [<c0419bf2>] driver_attach+0x19/0x1b [ 2.609394] [<c041a0f6>] ? __device_attach+0x31/0x31 [ 2.609528] [<c0419912>] bus_add_driver+0xd4/0x18b [ 2.609661] [<c041a609>] driver_register+0x74/0xa9 [ 2.609795] [<c030ce6f>] __pci_register_driver+0x4a/0x4d [ 2.609932] [<c08231bb>] ? ftrace_define_fields_drm_vblank_event_delivered+0x65/0x65 [ 2.610168] [<c03a05c5>] drm_pci_init+0x56/0xc9 [ 2.610302] [<c08231bb>] ? ftrace_define_fields_drm_vblank_event_delivered+0x65/0x65 [ 2.610538] [<c082321d>] i915_init+0x62/0x64 [ 2.610670] [<c01003e7>] do_one_initcall+0x7c/0x105 [ 2.610805] [<c07f9400>] ? do_early_param+0x3d/0x73 [ 2.610940] [<c0140cc6>] ? parse_args+0x16c/0x203 [ 2.611074] [<c07f9a4f>] kernel_init_freeable+0xdb/0x158 [ 2.611210] [<c054f9fe>] kernel_init+0xd/0xdf [ 2.611344] [<c0560937>] ret_from_kernel_thread+0x1b/0x28 [ 2.611479] [<c054f9f1>] ? rest_init+0xa5/0xa5 [ 2.611666] ---[ end trace cd346fb3f5b5c52d ]---
cu,
Knut
Quoted 5 lines · Knut Petersen
On 28.04.2014 15:26, Daniel Vetter wrote:
The patch below is a clear candidate for 3.15 as it fixes a regression introduced after 3.14Quoted 2 lines
Egbert Eich (1):
drm/i915/SDVO: For sysfs link put directory and target in correct order
Daniel, want me to pick that for -fixes?
Jani.
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Quoted 8 lines · Jani Nikula
Quoted 5 lines · Knut Petersen
On 28.04.2014 15:26, Daniel Vetter wrote:
The patch below is a clear candidate for 3.15 as it fixes a regression introduced after 3.14Quoted 2 lines
Egbert Eich (1):
drm/i915/SDVO: For sysfs link put directory and target in correct orderDaniel, want me to pick that for -fixes?
Yeah I geuss so. People never complained that the link isn't there, us adding it for one kernel release to the wrong place doesn't really sound too bothersome.
But if this unbreaks a system somewhere then it makes sense to apply to -fixes.
Knut, how exactly does your system blow up?
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Quoted 7 lines · Daniel Vetter
Quoted 6 lines · Jani Nikula
Quoted 4 lines · Knut Petersen
On 28.04.2014 15:26, Daniel Vetter wrote:
The patch below is a clear candidate for 3.15 as it fixes a regression introduced after 3.14Quoted 2 lines
Egbert Eich (1):
drm/i915/SDVO: For sysfs link put directory and target in correct orderDaniel, want me to pick that for -fixes?
Quoted 8 lines
Yeah I geuss so. People never complained that the link isn't there, us adding it for one kernel release to the wrong place doesn't really sound too bothersome.
But if this unbreaks a system somewhere then it makes sense to apply to -fixes.
Knut, how exactly does your system blow up?
Well, it's only the warning generated at boot time that would irritate users. As a patch is known and tested it's probably a good idea to fix it before people complain to lkml and bugzilla.
cu,
Knut
Quoted 1 line
-Daniel
Quoted 12 lines · Knut Petersen
Quoted 11 lines · Daniel Vetter
Quoted 6 lines · Jani Nikula
Quoted 4 lines · Knut Petersen
On 28.04.2014 15:26, Daniel Vetter wrote:
The patch below is a clear candidate for 3.15 as it fixes a regression introduced after 3.14Quoted 2 lines
Egbert Eich (1):
drm/i915/SDVO: For sysfs link put directory and target in correct orderDaniel, want me to pick that for -fixes?
Yeah I geuss so. People never complained that the link isn't there, us adding it for one kernel release to the wrong place doesn't really sound too bothersome.
Quoted 7 lines
Quoted 4 lines
But if this unbreaks a system somewhere then it makes sense to apply to -fixes.
Knut, how exactly does your system blow up?
Well, it's only the warning generated at boot time that would irritate users. As a patch is known and tested it's probably a good idea to fix it before people complain to lkml and bugzilla.
Ah, I didn't realize there's a warning, I've thought only the symlink goes the wrong way. In that case it's good to go for -fixes.
Thanks for pointing this out.
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Quoted 16 lines · Daniel Vetter
Quoted 15 lines · Knut Petersen
Quoted 14 lines · Daniel Vetter
Quoted 6 lines · Jani Nikula
Quoted 4 lines · Knut Petersen
On 28.04.2014 15:26, Daniel Vetter wrote:
The patch below is a clear candidate for 3.15 as it fixes a regression introduced after 3.14Quoted 2 lines
Egbert Eich (1):
drm/i915/SDVO: For sysfs link put directory and target in correct orderDaniel, want me to pick that for -fixes?
Yeah I geuss so. People never complained that the link isn't there, us adding it for one kernel release to the wrong place doesn't really sound too bothersome.
But if this unbreaks a system somewhere then it makes sense to apply to -fixes.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Knut, how exactly does your system blow up?
Well, it's only the warning generated at boot time that would irritate users. As a patch is known and tested it's probably a good idea to fix it before people complain to lkml and bugzilla.
Ah, I didn't realize there's a warning, I've thought only the symlink goes the wrong way. In that case it's good to go for -fixes.
Done.
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center