common: use a relative path to fsstress
PATCH 1/1 common: use a relative path to fsstress
All commands run as $qa_user should use a relative path so that missing access permissions on $HOME for root don't prevent running it. This fixes common/233 for me.
common/config +1 -1
@@ -134,7 +134,7 @@ export MOUNT_PROG="`set_prog_path mount`" export UMOUNT_PROG="`set_prog_path umount`" [ "$UMOUNT_PROG" = "" ] && _fatal "umount not found" -export FSSTRESS_PROG="`set_prog_path fsstress $PWD/ltp/fsstress`" +export FSSTRESS_PROG="./ltp/fsstress" [ "$FSSTRESS_PROG" = "" ] && _fatal "fsstress not found" export PERL_PROG="`set_prog_path perl`"
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 9 lines · Christoph Hellwig
All commands run as $qa_user should use a relative path so that missing access permissions on $HOME for root don't prevent running it. This fixes common/233 for me.
Signed-off-by Christoph Hellwig <[email protected]>
common/config export MOUNT_PROG="`set_prog_path mount`" · line 137
Quoted 5 lines
common/config +1
-1@@ -134,7 +134,7 @@ export MOUNT_PROG="`set_prog_path mount`" export UMOUNT_PROG="`set_prog_path umount`" [ "$UMOUNT_PROG" = "" ] && _fatal "umount not found" -export FSSTRESS_PROG="`set_prog_path fsstress $PWD/ltp/fsstress`" +export FSSTRESS_PROG="./ltp/fsstress"
Why remove the set_prog_path call? i.e. this should work:
+export FSSTRESS_PROG="set_prog_path fsstress ./ltp/fsstress"
Otherwise, a comment explaining why set_prog_path is not used just for this binary would be appropriate....
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 13 lines · Dave Chinner
common/config export MOUNT_PROG="`set_prog_path mount`" · line 137
Quoted 10 lines
Signed-off-by Christoph Hellwig <[email protected]>common/config +1
-1@@ -134,7 +134,7 @@ export MOUNT_PROG="`set_prog_path mount`" export UMOUNT_PROG="`set_prog_path umount`" [ "$UMOUNT_PROG" = "" ] && _fatal "umount not found" -export FSSTRESS_PROG="`set_prog_path fsstress $PWD/ltp/fsstress`" +export FSSTRESS_PROG="./ltp/fsstress"Why remove the
set_prog_pathcall? i.e. this should work:
Quoted 4 lines
+export FSSTRESS_PROG="
set_prog_path fsstress ./ltp/fsstress"Otherwise, a comment explaining why
set_prog_pathis not used just for this binary would be appropriate....
set_prog_path is only useful for tools found in $PATH, and except for fsstress we never use it for anything that we specify path to, so I don't really see the need for a comment here.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs