Skip to contentSkip to conversation

How user space applications load registers on HSW?]

[email protected]: Kenneth Graunke 4 participants 5 messages May 6, 2014 – May 13, 2014 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 20 lines · Rong R

Hi,

I am developing the HSW’s OCL driver in the linux. I encounter a LRI problem on HSW.

Some gpgpu's applications, which use the shared local memory, must load the L3CTRLREG2 and L3CTRLREG3 registers to allocate the SLM in the L3 cache.

So I add L3CTRLREG2 and L3CTRLREG3 to the gen7_render_regs to pass the cmds parse when exec buffer. But it still don’t work.

I notice that, on HSW, the commands that load the register, such as MI_LOAD_REGISTER_IMM, will be converted to NOOP by the GPU if the batch buffer's MI_BATCH_NON_SECURE_HSW bit is set. And after parse cmd, the MI_BATCH_NON_SECURE_HSW still set in the kernel. So HSW don’t accept LRI commands.

Quoted 5 lines

Can I load these registers in the user space? Or should I hack the kernel?

Yang Rong

I've been asking the kernel developers for the ability to LRI/LRM from userspace batches for around 1.5 years. Unfortunately, we're still waiting, and I honestly have no idea when they're going to finish it.

In the meantime, you can apply the attached patch to your kernel tree to disable the hardware scanner, letting you run whatever commands you want. Obviously, we can't ship this on production systems, but it will allow you to do your development without having to wait for the kernel team.

--Ken

drivers/gpu/drm/i915/i915_gem_execbuffer.c +1 -0
index a3ba9a8..86c173b 100644
@@ -995,6 +995,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
 		return ret;
 
 	flags = 0;
+	flags |= I915_DISPATCH_SECURE;
 	if (args->flags & I915_EXEC_SECURE) {
 		if (!file->is_master || !capable(CAP_SYS_ADMIN))
 		    return -EPERM;

_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

#2 lore raw

Re: [Mesa-dev] [[email protected]: How user space applications load registers on HSW?]

Hi, Ken,

Thanks for your patch.
But how do you release your driver on the HSW products? If can't LRI/LRM from userspace batches, almost all of OpenCL application can't run. So if I want to announce that the OpenCL driver support HSW, it must have a way to load L3CTRLREG2 and L3CTRLREG3.

Hi, Ben

There are only two immediate values need to load L3CTRLREG2 and L3CTRLREG3 to enable and disable SLM. So can I add the flag to exec buffer? when exec buffer receive this flag,
load the immediate to L3CTRLREG2 and L3CTRLREG3. Is it acceptable?

Thanks.

-----Original Message-----
From: Kenneth Graunke [mailto:[email protected]]
Sent: Wednesday, May 07, 2014 2:57 AM
To: Yang, Rong R
Cc: Ben Widawsky; mesa-dev; intel-gfx
Subject: Re: [Mesa-dev] [[email protected]: [Intel-gfx] How user space applications load registers on HSW?]

Quoted 20 lines · Rong R

Hi,

I am developing the HSW's OCL driver in the linux. I encounter a LRI problem on HSW.

Some gpgpu's applications, which use the shared local memory, must load the L3CTRLREG2 and L3CTRLREG3 registers to allocate the SLM in the L3 cache.

So I add L3CTRLREG2 and L3CTRLREG3 to the gen7_render_regs to pass the cmds parse when exec buffer. But it still don't work.

I notice that, on HSW, the commands that load the register, such as MI_LOAD_REGISTER_IMM, will be converted to NOOP by the GPU if the batch buffer's MI_BATCH_NON_SECURE_HSW bit is set. And after parse cmd, the MI_BATCH_NON_SECURE_HSW still set in the kernel. So HSW don't accept LRI commands.

Quoted 5 lines

Can I load these registers in the user space? Or should I hack the kernel?

Yang Rong

I've been asking the kernel developers for the ability to LRI/LRM from userspace batches for around 1.5 years. Unfortunately, we're still waiting, and I honestly have no idea when they're going to finish it.

In the meantime, you can apply the attached patch to your kernel tree to disable the hardware scanner, letting you run whatever commands you want. Obviously, we can't ship this on production systems, but it will allow you to do your development without having to wait for the kernel team.

--Ken

#3 lore raw

Re: [Mesa-dev] How user space applications load registers on HSW?

Quoted 7 lines · Rong R

Hi, Ken,

Thanks for your patch. But how do you release your driver on the HSW products? If can't LRI/LRM from userspace batches, almost all of OpenCL application can't run. So if I want to announce that the OpenCL driver support HSW, it must have a way to load L3CTRLREG2 and L3CTRLREG3.

Most of the OpenGL features don't need LRI/LRM. Currently, only a few OpenGL 4.0 extensions (ARB_transform_feedback2/3/instanced) and the perforrmance monitoring extensions need LRI/LRM...and we just don't ship those on Haswell yet. I'd really like to, but we can't yet.

You'll need to talk to Jesse, Brad, and Daniel to figure out when the kernel interface will be finished.

--Ken

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to Yang, Rong R
Quoted 5 lines · Rong R

Hi, Ken,

Thanks for your patch.
But how do you release your driver on the HSW products? If can't LRI/LRM from userspace batches, almost all of OpenCL application can't run. So if I want to announce that the OpenCL driver support HSW, it must have a way to load L3CTRLREG2 and L3CTRLREG3.

mesa doesn't do L3 control afaik.

Quoted 4 lines

Hi, Ben

There are only two immediate values need to load L3CTRLREG2 and L3CTRLREG3 to enable and disable SLM. So can I add the flag to exec buffer? when exec buffer receive this flag,
load the immediate to L3CTRLREG2 and L3CTRLREG3. Is it acceptable?

I think I'll reject this in the hopes that this will speed up the command parser ...

Thanks, Daniel

Quoted 46 lines

Thanks.

-----Original Message-----
From: Kenneth Graunke [mailto:[email protected]]
Sent: Wednesday, May 07, 2014 2:57 AM
To: Yang, Rong R
Cc: Ben Widawsky; mesa-dev; intel-gfx
Subject: Re: [Mesa-dev] [[email protected]: [Intel-gfx] How user space applications load registers on HSW?]

Quoted 20 lines · Rong R

Hi,

I am developing the HSW's OCL driver in the linux. I encounter a LRI problem on HSW.

Some gpgpu's applications, which use the shared local memory, must load the L3CTRLREG2 and L3CTRLREG3 registers to allocate the SLM in the L3 cache.

So I add L3CTRLREG2 and L3CTRLREG3 to the gen7_render_regs to pass the cmds parse when exec buffer. But it still don't work.

I notice that, on HSW, the commands that load the register, such as MI_LOAD_REGISTER_IMM, will be converted to NOOP by the GPU if the batch buffer's MI_BATCH_NON_SECURE_HSW bit is set. And after parse cmd, the MI_BATCH_NON_SECURE_HSW still set in the kernel. So HSW don't accept LRI commands.

Quoted 5 lines

Can I load these registers in the user space? Or should I hack the kernel?

Yang Rong

I've been asking the kernel developers for the ability to LRI/LRM from userspace batches for around 1.5 years. Unfortunately, we're still waiting, and I honestly have no idea when they're going to finish it.

In the meantime, you can apply the attached patch to your kernel tree to disable the hardware scanner, letting you run whatever commands you want. Obviously, we can't ship this on production systems, but it will allow you to do your development without having to wait for the kernel team.

--Ken
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#5 lore raw

Hi Daniel,
We need a solution for this.
Without correct L3 config setting, all the OpenCL programs that use SLM will fail.
We cannot set a default L3 config for all OCL programs, because L3 config for SLM will slowdown kernel that are not using SLM. When do you think the command parser could be ready?

Thanks
Zou Nanhai

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Tuesday, May 13, 2014 2:11 PM
To: Yang, Rong R
Cc: Kenneth Graunke; Zou, Nanhai; mesa-dev; Ben Widawsky; intel-gfx
Subject: Re: [Mesa-dev] [[email protected]: [Intel-gfx] How user space applications load registers on HSW?]

Quoted 5 lines · Rong R

Hi, Ken,

Thanks for your patch.
But how do you release your driver on the HSW products? If can't LRI/LRM from userspace batches, almost all of OpenCL application can't run. So if I want to announce that the OpenCL driver support HSW, it must have a way to load L3CTRLREG2 and L3CTRLREG3.

mesa doesn't do L3 control afaik.

Quoted 4 lines

Hi, Ben

There are only two immediate values need to load L3CTRLREG2 and
L3CTRLREG3 to enable and disable SLM. So can I add the flag to exec buffer? when exec buffer receive this flag, load the immediate to L3CTRLREG2 and L3CTRLREG3. Is it acceptable?

I think I'll reject this in the hopes that this will speed up the command parser ...

Thanks, Daniel

Quoted 40 lines

Thanks.

-----Original Message-----
From: Kenneth Graunke [mailto:[email protected]]
Sent: Wednesday, May 07, 2014 2:57 AM
To: Yang, Rong R
Cc: Ben Widawsky; mesa-dev; intel-gfx
Subject: Re: [Mesa-dev] [[email protected]: [Intel-gfx] How user space applications load registers on HSW?]

Quoted 20 lines · Rong R

Hi,

I am developing the HSW's OCL driver in the linux. I encounter a LRI problem on HSW.

Some gpgpu's applications, which use the shared local memory, must load the L3CTRLREG2 and L3CTRLREG3 registers to allocate the SLM in the L3 cache.

So I add L3CTRLREG2 and L3CTRLREG3 to the gen7_render_regs to pass the cmds parse when exec buffer. But it still don't work.

I notice that, on HSW, the commands that load the register, such as MI_LOAD_REGISTER_IMM, will be converted to NOOP by the GPU if the batch buffer's MI_BATCH_NON_SECURE_HSW bit is set. And after parse cmd, the MI_BATCH_NON_SECURE_HSW still set in the kernel. So HSW don't accept LRI commands.

Quoted 5 lines

Can I load these registers in the user space? Or should I hack the kernel?

Yang Rong

I've been asking the kernel developers for the ability to LRI/LRM from userspace batches for around 1.5 years. Unfortunately, we're still waiting, and I honestly have no idea when they're going to finish it.

Quoted 7 lines

In the meantime, you can apply the attached patch to your kernel tree to disable the hardware scanner, letting you run whatever commands you want. Obviously, we can't ship this on production systems, but it will allow you to do your development without having to wait for the kernel team.

--Ken
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch