Skip to contentSkip to conversation

XFS development tree branch, xfs-libxfs-in-kernel-RFC, updated. xfs-for-linus-3.15-rc2-53-g70aadae

XFS updates [email protected] 1 participant 1 message May 8, 2014

lore
Share & tools
lore
#0 lore raw

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "XFS development tree".

The branch, xfs-libxfs-in-kernel-RFC has been updated
70aadae libxfs: fix modular build

      from  6579dd808ddf0ddc10e59e715dc8f2eb09705203 (commit)

Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.

- Log ----------------------------------------------------------------- commit 70aadae524c437b3c38969316d2dbab5c2c811f2

Author: Dave Chinner <[email protected]>
Date:   Thu May 8 11:12:09 2014 +1000

libxfs: fix modular build

As reported by Brain Foster:

Note that the Makefile structure between the core and libxfs/ subdir appears to be busted for module compiles. It attempts to create a libxfs.ko and doesn't appear to create any real link dependency between the logical modules:

...
WARNING: "__tracepoint_xfs_dir2_sf_create" [fs/xfs/libxfs/libxfs.ko] undefined!
WARNING: "__tracepoint_xfs_da_root_join" [fs/xfs/libxfs/libxfs.ko] undefined!
WARNING: "xfs_trans_mod_sb" [fs/xfs/libxfs/libxfs.ko] undefined!
WARNING: "xfs_extent_busy_insert" [fs/xfs/libxfs/libxfs.ko] undefined!
WARNING: "__tracepoint_xfs_dir2_sf_addname" [fs/xfs/libxfs/libxfs.ko] undefined!
CC fs/xfs/xfs.mod.o
CC fs/xfs/libxfs/libxfs.mod.o
LD [M] fs/xfs/xfs.ko
LD [M] fs/xfs/libxfs/libxfs.ko

Fix it by converting libxfs to be a static library, and hack the fs/xfs/xfs.o linker commands to include it directly and so completely avoid the need for a libxfs.ko module until we have sorted out all the circular dependency issues.

-----------------------------------------------------------------------

Summary of changes:

 fs/xfs/Makefile        | 22 +++++++++++++++++++---
 fs/xfs/libxfs/Makefile | 12 +++++++-----
 2 files changed, 26 insertions(+), 8 deletions(-)

hooks/post-receive

Signature · 6 lines
XFS development tree

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs