applicom: dereferencing NULL on error path

PATCH New Dan Carpenter 1 participant 1 message May 9, 2014

Subsystems (2)

Kernel janitors Char and misc drivers

lore

Share & tools

lore

Dan Carpenter

author

2014-05-09 11:59 UTC #0 lore raw

PATCH 1/1 applicom: dereferencing NULL on error path

This is a static checker fix. The "dev" variable is always NULL after the while statement so we would be dereferencing a NULL pointer here.

Fixes 819a3eba4233 ('[PATCH] applicom: fix error handling')

Signed-off-by Dan Carpenter <[email protected]>

drivers/char/applicom.c +0 -1

index 974321a..1479030 100644
@@ -345,7 +345,6 @@ out:
 			free_irq(apbs[i].irq, &dummy);
 		iounmap(apbs[i].RamIO);
 	}
-	pci_disable_device(dev);
 	return ret;
 }