Fix missing a blank line after declaration for usbip
PATCH 1/1 Fix missing a blank line after declaration for usbip
Hi,
Please find attached patch which fixes most of "Missing blank line after declaration" in drivers/staging/usbip directory.
There are still two WARNINGS reported which refers to the struct declaration, and it seems to be a problem with the checkpatck.pl script.
Regards
Pawel Lebioda
Quoted 1 line
From
6fba281794ce0466e88c785123f906b7d3654bc2Mon Sep 17 00:00:00 2001
From: Pawel Lebioda <[email protected]>
Date: Sat, 10 May 2014 16:35:50 +0200
Subject: [PATCH] Fix missing a blank line after declaration for usbip
--- drivers/staging/usbip/stub_dev.c | 1 + drivers/staging/usbip/stub_tx.c | 1 + drivers/staging/usbip/usbip_common.h | 2 ++ drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 +- drivers/staging/usbip/userspace/src/usbip_attach.c | 1 + drivers/staging/usbip/userspace/src/usbipd.c | 6 +++++- drivers/staging/usbip/vhci_hcd.c | 2 ++ 7 files changed, 13 insertions(+), 2 deletions(-)
drivers/staging/usbip/stub_dev.c +1 -0
@@ -99,6 +99,7 @@ static ssize_t store_sockfd(struct device *dev, struct device_attribute *attr,if (sockfd !=-1 ) {int err; +dev_info (dev,"stub up\n" );spin_lock_irq (&sdev->ud.lock);
drivers/staging/usbip/stub_tx.c +1 -0
@@ -218,6 +218,7 @@ static int stub_send_ret_submit(struct stub_device *sdev)*/ int i; +for (i =0 ; i < urb->number_of_packets; i++) { iov[iovnum].iov_base = urb->transfer_buffer + urb->iso_frame_desc[i].offset;
drivers/staging/usbip/usbip_common.h +2 -0
@@ -321,12 +321,14 @@ int usbip_event_happened(struct usbip_device *ud);static inline int interface_to_busnum (struct usb_interface *interface) {struct usb_device *udev =interface_to_usbdev (interface); +return udev->bus->busnum; }static inline int interface_to_devnum (struct usb_interface *interface) {struct usb_device *udev =interface_to_usbdev (interface); +return udev->devnum; }
drivers/staging/usbip/userspace/libsrc/usbip_common.c +1 -1
@@ -75,6 +75,7 @@ const char *usbip_speed_string(int num)void dump_usb_interface (struct usbip_usb_interface *uinf) {char buff[100 ]; + usbip_names_get_class(buff, sizeof(buff), uinf->bInterfaceClass, uinf->bInterfaceSubClass,
@@ -86,7 +87,6 @@ void dump_usb_device(struct usbip_usb_device *udev) {char buff[100 ]; -dbg ("%-20s = %s" ,"path" , udev->path);dbg ("%-20s = %s" ,"busid" , udev->busid);
drivers/staging/usbip/userspace/src/usbip_attach.c +1 -0
@@ -56,6 +56,7 @@ static int record_connection(char *host, char *port, char *busid, int rhport)/* if VHCI_STATE_PATH exists, then it better be a directory */ if (errno ==EEXIST ) {struct stat s; + ret =stat (VHCI_STATE_PATH , &s);if (ret <0 )return -1 ;
drivers/staging/usbip/userspace/src/usbipd.c +5 -1
@@ -372,6 +372,7 @@ static int listen_all_addrinfo(struct addrinfo *ai_head, int sockfdlist[],for (ai = ai_head; ai && nsockfd < maxsockfd; ai = ai->ai_next) {int sock; +addrinfo_to_text (ai, ai_buf, ai_buf_size);dbg ("opening %s" , ai_buf); sock =socket (ai->ai_family, ai->ai_socktype, ai->ai_protocol);
@@ -461,7 +462,9 @@ static void write_pid_file() {if (pid_file) {dbg ("creating pid file %s" , pid_file); -FILE *fp =fopen (pid_file,"w" ); +FILE *fp; + + fp =fopen (pid_file,"w" );if (!fp) {err ("pid_file: %s: %d (%s)" , pid_file, errno,strerror (errno));
@@ -602,6 +605,7 @@ int main(int argc, char *argv[])int daemonize =0 ;int ipv4 =0 , ipv6 =0 ;int opt, rc =-1 ; + pid_file =NULL ; usbip_use_stderr =1 ;
drivers/staging/usbip/vhci_hcd.c +2 -0
@@ -635,6 +635,7 @@ static int vhci_urb_dequeue(struct usb_hcd *hcd, struct urb *urb, int status) {int ret =0 ; + ret =usb_hcd_check_unlink_urb (hcd, urb, status);if (ret) {spin_unlock (&the_controller->lock);
@@ -885,6 +886,7 @@ static int vhci_start(struct usb_hcd *hcd)for (rhport =0 ; rhport <VHCI_NPORTS ; rhport++) {struct vhci_device *vdev = &vhci->vdev[rhport]; +vhci_device_init (vdev); vdev->rhport = rhport; }
Signature · 2 lines
1.8.3.2 Signed-off-by: Pawel Lebioda <[email protected]>
Send the patch inline so it can be applied automatically with git am.
Quoted 9 lines · Pawel Lebioda
Hi,
Please find attached patch which fixes most of "Missing blank line after declaration" in
drivers/staging/usbipdirectory.There are still two WARNINGS reported which refers to the struct declaration, and it seems to be a problem with the checkpatck.pl script.
Quoted 8 lines
Regards
Pawel LebiodaQuoted 1 line
From
6fba281794ce0466e88c785123f906b7d3654bc2Mon Sep 17 00:00:00 2001From: Pawel Lebioda <[email protected]>
Date: Sat, 10 May 2014 16:35:50 +0200
Subject: [PATCH] Fix missing a blank line after declaration for usbip
Subject should have a subsystem prefix.
[PATCH] Staging: usbip: missing a blank lines after declarations
There is no Signed-off-by line.
Put the stuff from the email into the changelog.
regards,
dan carpenter