Skip to contentSkip to conversation

Patman removes author's Signed-off-by credit

U-Boot Masahiro Yamada 2 participants 3 messages May 14, 2014 – May 15, 2014

lore
Share & tools
lore

Masahiro Yamada

author Acked-by Simon Glass
#0 lore raw

Hi Simon,

I suspect there is something wrong with Patman since commit 102061bd (patman: Avoid duplicate sign-offs).

For example, my commit log is like follows

sandbox: set sandbox's vendor to null

Because sandbox is not a real hardware, setting vendor=sandbox is almost meaningless.

This commit sets sandbox's vendor field to '-'.

It is a good thing that it decreases one level directory hierarchy. The files board/sandbox/sandbox/* have been moved to board/sandbox/*.

Series-to: uboot
Series-cc: sjg
Series-version: 2
Series-changes: 2
- Rebase

When I run "tools/patman/patman -c 1",
Patman removes all Signed-off-by credits and checkpatch.pl reports missing Signed-off-by credit error.

1 errors, 0 warnings, 0 checks for 0001-sandbox-set-sandbox-s-vendor-to-null.patch:
error: <unknown>,0: Missing Signed-off-by: line(s)

checkpatch.pl found 1 error(s), 0 warning(s), 0 checks(s)

I think this is worse than dupulicated signed-off-by.

Best Regards
Masahiro Yamada

#1 lore raw

Hi Masahiro,

Quoted 34 lines · Masahiro Yamada

Hi Simon,

I suspect there is something wrong with Patman since commit 102061bd (patman: Avoid duplicate sign-offs).

For example, my commit log is like follows

sandbox: set sandbox's vendor to null

Because sandbox is not a real hardware, setting vendor=sandbox is almost meaningless.

This commit sets sandbox's vendor field to '-'.

It is a good thing that it decreases one level directory hierarchy. The files board/sandbox/sandbox/* have been moved to board/sandbox/*.

Series-to: uboot
Series-cc: sjg
Series-version: 2
Series-changes: 2
- Rebase

When I run "tools/patman/patman -c 1",
Patman removes all Signed-off-by credits and checkpatch.pl reports missing Signed-off-by credit error.

Quoted 7 lines

1 errors, 0 warnings, 0 checks for 0001-sandbox-set-sandbox-s-vendor-to-null.patch:
error: <unknown>,0: Missing Signed-off-by: line(s)

checkpatch.pl found 1 error(s), 0 warning(s), 0 checks(s)

I think this is worse than dupulicated signed-off-by.

Yes I noticed it too. I am not sure how I introduced this bug, but it serves me right for not writing a unit test. Please try this patch.

http://patchwork.ozlabs.org/patch/348502/

Regards,
Simon

#2 lore raw

Hi Simon,

Quoted 6 lines · On Wed, 14 May 2014 19:41:55 -0600 Simon Glass <[email protected]> wrote:

Yes I noticed it too. I am not sure how I introduced this bug, but it serves me right for not writing a unit test. Please try this patch.

http://patchwork.ozlabs.org/patch/348502/

Oops, I overlooked this patch.
I confirmed it fixed the problem.
Thanks!

Best Regards
Masahiro Yamada