Skip to contentSkip to conversation

mm: fix some indenting in cmpxchg_double_slab()

PATCH In review Dan Carpenter 2 participants 2 messages May 14, 2014

Subsystems (3)
Memory management Kernel janitors Slab allocator
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 mm: fix some indenting in cmpxchg_double_slab()

The return statement goes with the cmpxchg_double() condition so it needs to be indented another tab.

Also these days the fashion is to line function parameters up, and it looks nicer that way because then the "freelist_new" is not at the same indent level as the "return 1;".

Signed-off-by Dan Carpenter <[email protected]>
mm/slub.c +6 -6
index fdf0fe4..d96faa2 100644
@@ -382,9 +382,9 @@ static inline bool __cmpxchg_double_slab(struct kmem_cache *s, struct page *page
     defined(CONFIG_HAVE_ALIGNED_STRUCT_PAGE)
 	if (s->flags & __CMPXCHG_DOUBLE) {
 		if (cmpxchg_double(&page->freelist, &page->counters,
-			freelist_old, counters_old,
-			freelist_new, counters_new))
-		return 1;
+				   freelist_old, counters_old,
+				   freelist_new, counters_new))
+			return 1;
 	} else
 #endif
 	{

@@ -418,9 +418,9 @@ static inline bool cmpxchg_double_slab(struct kmem_cache *s, struct page *page,
     defined(CONFIG_HAVE_ALIGNED_STRUCT_PAGE)
 	if (s->flags & __CMPXCHG_DOUBLE) {
 		if (cmpxchg_double(&page->freelist, &page->counters,
-			freelist_old, counters_old,
-			freelist_new, counters_new))
-		return 1;
+				   freelist_old, counters_old,
+				   freelist_new, counters_new))
+			return 1;
 	} else
 #endif
 	{
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Dan Carpenter

The return statement goes with the cmpxchg_double() condition so it needs to be indented another tab.

Also these days the fashion is to line function parameters up, and it looks nicer that way because then the "freelist_new" is not at the same indent level as the "return 1;".

Signed-off-by Dan Carpenter <[email protected]>
Acked-by David Rientjes <[email protected]>