Skip to contentSkip to conversation

staging: ozwpan: remove redundant NULL check for devs

PATCH Superseded Daeseok Youn 2 participants 3 messages May 16, 2014 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: ozwpan: remove redundant NULL check for devs

Quoted 1 line

From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001

From: Daeseok Youn <[email protected]>
Date: Fri, 16 May 2014 17:02:04 +0900
Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs

The "devs" is a pointer to g_net_dev in ozmain.c. g_net_dev has a default value as empty string. So "devs" cannot be NULL, removes NULL check for "devs".

---
 drivers/staging/ozwpan/ozproto.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/ozwpan/ozproto.c +1 -1
index f09acd0..767cac4 100644
@@ -765,7 +765,7 @@ static char *oz_get_next_device_name(char *s, char *dname, int max_size)
 int oz_protocol_init(char *devs)
 {
 	skb_queue_head_init(&g_rx_queue);
-	if (devs && (devs[0] == '*')) {
+	if (devs[0] == '*') {
 		oz_binding_add(NULL);
 	} else {
 		char d[32];
Signature · 1 line
1.7.1
#1 lore raw
Quoted 5 lines · Daeseok Youn
Quoted 1 line

From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001

From: Daeseok Youn <[email protected]>
Date: Fri, 16 May 2014 17:02:04 +0900
Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs

Your patches before were fine. Why do you have these lines in them now? Please resend.

Otherwise this looks fine.

regards,
dan carpenter

#2 lore raw

Hi, Dan

2014-05-16 18:03 GMT+09:00 Dan Carpenter <[email protected]>:

Quoted 9 lines · Daeseok Youn
Quoted 5 lines
Quoted 1 line

From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001

From: Daeseok Youn <[email protected]>
Date: Fri, 16 May 2014 17:02:04 +0900
Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs

Your patches before were fine. Why do you have these lines in them now? Please resend.

Oh.. I actually made a script for mutt and I didn't notice it. I will remove these lines and resend it.

Thanks.
Regards,
Daeseok Youn.

Quoted 7 lines

Otherwise this looks fine.

regards,
dan carpenter