Skip to contentSkip to conversation

time to move fs/bio.c to block/ ?

DISCUSSION Christoph Hellwig 5 participants 14 messages May 19, 2014 – May 20, 2014

lore
Share & tools
lore
#0 lore raw

I recently saw patches to fs/bio.c that were sent to Al instead of Jens. I think having bio.c in fs/ is rather confusing, so maybe it's time to include the simple git-mv for it in the your for-next tree?

#1 lore raw
Quoted 3 lines · Christoph Hellwig

I recently saw patches to fs/bio.c that were sent to Al instead of Jens. I think having bio.c in fs/ is rather confusing, so maybe it's time to include the simple git-mv for it in the your for-next tree?

Sure, I've been thinking that too for a while. I'll do the move.

Signature · 1 line
Jens Axboe
#2 lore raw
Quoted 6 lines · Jens Axboe
Quoted 3 lines · Christoph Hellwig

I recently saw patches to fs/bio.c that were sent to Al instead of Jens. I think having bio.c in fs/ is rather confusing, so maybe it's time to include the simple git-mv for it in the your for-next tree?

Sure, I've been thinking that too for a while. I'll do the move.

While you are at it, could you take bio-integrity.c with it? _That_ has zero excuse being anywhere in fs/* - not even "filesystem code uses quite a few functions from that sucker" as with bio.c. FWIW, consider the move ACKed.

#3 lore raw
Quoted 4 lines · Al Viro

While you are at it, could you take bio-integrity.c with it? _That_ has zero excuse being anywhere in fs/* - not even "filesystem code uses quite a few functions from that sucker" as with bio.c. FWIW, consider the move ACKed.

Various function in there aren't used at all in fact. But yes, it should also move.

#4 lore raw
In reply to Al Viro
Quoted 6 lines · Al Viro
Quoted 5 lines · Jens Axboe
Quoted 3 lines · Christoph Hellwig

I recently saw patches to fs/bio.c that were sent to Al instead of Jens. I think having bio.c in fs/ is rather confusing, so maybe it's time to include the simple git-mv for it in the your for-next tree?

Quoted 6 lines
Quoted 1 line

Sure, I've been thinking that too for a while. I'll do the move.

While you are at it, could you take bio-integrity.c with it? _That_ has zero excuse being anywhere in fs/* - not even "filesystem code uses quite a few functions from that sucker" as with bio.c. FWIW, consider the move ACKed.

Yeah, I did include that in the move.

Signature · 1 line
Jens Axboe
#5 lore raw
Quoted 6 lines · Jens Axboe
Quoted 4 lines

While you are at it, could you take bio-integrity.c with it? _That_ has zero excuse being anywhere in fs/* - not even "filesystem code uses quite a few functions from that sucker" as with bio.c. FWIW, consider the move ACKed.

Yeah, I did include that in the move.

Other candidates to move to block/ might be ioprio.c and no-block.c

#6 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 6 lines · Jens Axboe
Quoted 4 lines

While you are at it, could you take bio-integrity.c with it? _That_ has zero excuse being anywhere in fs/* - not even "filesystem code uses quite a few functions from that sucker" as with bio.c. FWIW, consider the move ACKed.

Yeah, I did include that in the move.

Other candidates to move to block/ might be ioprio.c and no-block.c

Yes, lets move those as well, now we're at it.

Signature · 1 line
Jens Axboe
#7 lore raw
In reply to Christoph Hellwig
Quoted 9 lines · Christoph Hellwig
Quoted 6 lines · Jens Axboe
Quoted 4 lines

While you are at it, could you take bio-integrity.c with it? _That_ has zero excuse being anywhere in fs/* - not even "filesystem code uses quite a few functions from that sucker" as with bio.c. FWIW, consider the move ACKed.

Yeah, I did include that in the move.

Other candidates to move to block/ might be ioprio.c and no-block.c

ACK on ioprio.c (BTW, looking at block... WTF is the story with that pile of blk-* in there? IOW, why blk-exec.c is better than exec.c, etc.?)

As for fs/no-block.c... IMO that's a bad idea - it makes sense only if we take fs/block.c there as well, and that one wants fs/internal.h.

Why do we need that ->llseek = noop_llseek there, while we are at it? Its ->open() always fails, so how is ->llseek() going to get looked at, let alone called?

#8 lore raw
Quoted 6 lines · Al Viro

ACK on ioprio.c (BTW, looking at block... WTF is the story with that pile of blk-* in there? IOW, why blk-exec.c is better than exec.c, etc.?)

As for fs/no-block.c... IMO that's a bad idea - it makes sense only if we take fs/block.c there as well, and that one wants fs/internal.h.

Right, we still have block_dev.c which is more VFS than block. Makes sense to keep no-block.c then.

Quoted 3 lines

Why do we need that ->llseek = noop_llseek there, while we are at it? Its ->open() always fails, so how is ->llseek() going to get looked at, let alone called?

Looks like a larger mechanical conversation of lseek instances..

#9 lore raw
In reply to Al Viro
Quoted 7 lines · Al Viro
Quoted 6 lines · Christoph Hellwig
Quoted 5 lines · Jens Axboe
Quoted 4 lines

While you are at it, could you take bio-integrity.c with it? _That_ has zero excuse being anywhere in fs/* - not even "filesystem code uses quite a few functions from that sucker" as with bio.c. FWIW, consider the move ACKed.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Yeah, I did include that in the move.

Other candidates to move to block/ might be ioprio.c and no-block.c

ACK on ioprio.c (BTW, looking at block... WTF is the story with that pile of blk-* in there? IOW, why blk-exec.c is better than exec.c, etc.?)

Intent was to separate the core code from the other code, back when it was all split from ll_rw_blk.c. I'd still prefer it that way, as opposed to (eg) putting it in block/core/exec.c.

Signature · 1 line
Jens Axboe
#10 lore raw
In reply to Jens Axboe
Quoted 6 lines · Jens Axboe
Quoted 3 lines · Christoph Hellwig

I recently saw patches to fs/bio.c that were sent to Al instead of Jens. I think having bio.c in fs/ is rather confusing, so maybe it's time to include the simple git-mv for it in the your for-next tree?

Sure, I've been thinking that too for a while. I'll do the move.

mm/bounce.c is another one.

Thanks,

Signature · 1 line
Ming Lei
#11 lore raw
Quoted 9 lines · Ming Lei
Quoted 6 lines · Jens Axboe
Quoted 3 lines · Christoph Hellwig

I recently saw patches to fs/bio.c that were sent to Al instead of Jens. I think having bio.c in fs/ is rather confusing, so maybe it's time to include the simple git-mv for it in the your for-next tree?

Sure, I've been thinking that too for a while. I'll do the move.

mm/bounce.c is another one.

True, that should be moved as well.

Signature · 1 line
Jens Axboe
#12 lore raw
In reply to Christoph Hellwig
Quoted 3 lines · Christoph Hellwig

I recently saw patches to fs/bio.c that were sent to Al instead of Jens. I think having bio.c in fs/ is rather confusing, so maybe it's time to include the simple git-mv for it in the your for-next tree?

Hi, Christoph, Jens,

BTW, just out of curiosity, the VFS infrastructure code is just scatterd around the fs directory, which is quite suprised to a new comer that why there is "no" vfs stuff in fs directory. Does it make sense to also collect them into a dedicated sub-dir, maybe vfs. IMHO, this could make code skeleton more clear and could avoid such mis-sending patches in a long term maintainability view.

Thanks,
Jianyu Zhan

#13 lore raw
Quoted 8 lines · Jianyu Zhan

Hi, Christoph, Jens,

BTW, just out of curiosity, the VFS infrastructure code is just scatterd around the fs directory, which is quite suprised to a new comer that why there is "no" vfs stuff in fs directory. Does it make sense to also collect them into a dedicated sub-dir, maybe vfs. IMHO, this could make code skeleton more clear and could avoid such mis-sending patches in a long term maintainability view.

fs/*.[ch] shouldn't be much that isn't VFS in the broader sense (including library functions). Besides the block files the only the only things that might make sense to move out are binfmt*.c, signalfd.c and timerfd.c (to kernel/ ?).

Quoted 3 lines

Thanks,
Jianyu Zhan

---end quoted text---