Skip to contentSkip to conversation

kvm_stat: add option to display non tracepoint based stats

PATCH In review Marcelo Tosatti 2 participants 2 messages May 20, 2014 – May 21, 2014 KVM

lore
Share & tools
lore

Marcelo Tosatti

author
#0 lore raw

PATCH 1/1 kvm_stat: add option to display non tracepoint based stats

The old stats contain information not available in the tracepoints.

Signed-off-by Marcelo Tosatti <[email protected]>
scripts/kvm/kvm_stat +12 -3
index 762544b..6ac3b21 100755
@@ -493,12 +493,21 @@ options.add_option('-f', '--fields',
                    dest = 'fields',
                    help = 'fields to display (regex)',
                    )
+options.add_option('-o', '--old',
+                   action = 'store_true',
+                   default = False,
+                   dest = 'old',
+                   help = 'show kvm statistics counters (not tracepoint based)',
+                   )
 (options, args) = options.parse_args(sys.argv)
 
-try:
-    provider = TracepointProvider()
-except:
+if options.old:
     provider = DebugfsProvider()
+else:
+    try:
+        provider = TracepointProvider()
+    except:
+        provider = DebugfsProvider()
 
 stats = Stats(provider, fields = options.fields)
maintainer
#1 lore raw

Il 20/05/2014 20:38, Marcelo Tosatti ha scritto:

Quoted 25 lines

The old stats contain information not available in the tracepoints.

Signed-off-by Marcelo Tosatti <[email protected]>
scripts/kvm/kvm_stat +6 -3
index 762544b..6ac3b21 100755
@@ -493,12 +493,21 @@ options.add_option('-f', '--fields',
                    dest = 'fields',
                    help = 'fields to display (regex)',
                    )
+options.add_option('-o', '--old',
+                   action = 'store_true',
+                   default = False,
+                   dest = 'old',
+                   help = 'show kvm statistics counters (not tracepoint based)',
+                   )
 (options, args) = options.parse_args(sys.argv)
 
-try:
-    provider = TracepointProvider()
-except:

scripts/kvm/kvm_stat options.add_option('-f', '--fields', · line 513

Quoted 10 lines
scripts/kvm/kvm_stat +6 -0
+if options.old:
     provider = DebugfsProvider()
+else:
+    try:
+        provider = TracepointProvider()
+    except:
+        provider = DebugfsProvider()
 
 stats = Stats(provider, fields = options.fields)

Let's instead show information from both providers. I am sending a patch.

Paolo