Skip to contentSkip to conversation

i2c: removal of s6000 driver

DISCUSSION Wolfram Sang 6 participants 11 messages May 21, 2014 – Aug 9, 2014 3 messages not in the archive I2C subsystem host drivers

lore
Share & tools
lore
#0 lore raw

Hi,

I recently discovered that the I2C core of the S6000 is basically a Designware IP core. For the latter we have a frequently used and updated i2c driver while the S6000 driver seems to bitrot. My wish is to remove the s6000 driver in favor of the DesignWare one. My question is if there is someone who could test such a change on real hardware? Grepping through sources, it looks to me like the only candidate in mainline is the s6105, yet its defconfig doesn't even have I2C activated? Can we remove this driver right away? Am I missing something?

Kind regards,

Wolfram

#1 lore raw

Hi Wolfram,

Quoted 8 lines · Wolfram Sang

I recently discovered that the I2C core of the S6000 is basically a Designware IP core. For the latter we have a frequently used and updated i2c driver while the S6000 driver seems to bitrot. My wish is to remove the s6000 driver in favor of the DesignWare one. My question is if there is someone who could test such a change on real hardware? Grepping through sources, it looks to me like the only candidate in mainline is the s6105, yet its defconfig doesn't even have I2C activated? Can we remove this driver right away? Am I missing something?

Removing drivers without a replacement tested and running doesn't make much sense, except one chooses to drop support for the whole S6 thing right away. Which I don't support.

best regards,
Oskar

#2 lore raw
Quoted 3 lines · Oskar Schirmer

Removing drivers without a replacement tested and running doesn't make much sense, except one chooses to drop support for the whole S6 thing right away. Which I don't support.

Oscar, do you mean that you don't support the platform or that you don't support its removal?

I'm pretty sure it's broken now, since there's no hardware to test on and even no compiler for it (IIRC a recent attempt to get a toolchain overlay for s6000 failed, see
http://lists.linux-xtensa.org/pipermail/linux-xtensa/Week-of-Mon-20130617/001099.html
).

Signature · 2 lines
Thanks.
-- Max
#3 lore raw
In reply to Oskar Schirmer

Hi Oskar,

I might have asked you before, but do you still have the overlay for the S6000 somewhere laying around?

Thanks,
-Chris

Quoted 17 lines · Oskar Schirmer

Hi Wolfram,

Quoted 8 lines · Wolfram Sang

I recently discovered that the I2C core of the S6000 is basically a Designware IP core. For the latter we have a frequently used and updated i2c driver while the S6000 driver seems to bitrot. My wish is to remove the s6000 driver in favor of the DesignWare one. My question is if there is someone who could test such a change on real hardware? Grepping through sources, it looks to me like the only candidate in mainline is the s6105, yet its defconfig doesn't even have I2C activated? Can we remove this driver right away? Am I missing something?

Removing drivers without a replacement tested and running doesn't make much sense, except one chooses to drop support for the whole S6 thing right away. Which I don't support.

best regards,
Oskar

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 2 lines · czankel

I might have asked you before, but do you still have the overlay for the S6000 somewhere laying around?

No, but maybe Daniel has?

Oskar

#6 lore raw
Quoted 5 lines · Oskar Schirmer
Quoted 2 lines · czankel

I might have asked you before, but do you still have the overlay for the S6000 somewhere laying around?

No, but maybe Daniel has?

At work we still have the overlay as part of the board support package we created for the s6105. But I'd prefer to talk to someone at Stretch first before handing out copies. Unfortunately I'm on vacation right now and will be without internet access from tomorrow to Sunday.

Daniel

A message that is not in the archive (sent off-list or not yet received): 20140527223557.GA9594-G/[email protected]

#8 lore raw
Quoted 11 lines · Daniel Glöckner
Quoted 5 lines · Oskar Schirmer
Quoted 2 lines · czankel

I might have asked you before, but do you still have the overlay for the S6000 somewhere laying around?

No, but maybe Daniel has?

At work we still have the overlay as part of the board support package we created for the s6105. But I'd prefer to talk to someone at Stretch first before handing out copies. Unfortunately I'm on vacation right now and will be without internet access from tomorrow to Sunday.

Ping. Is that the only known platform for the s6000?

#9 lore raw
Quoted 7 lines · Wolfram Sang
Quoted 4 lines · Daniel Glöckner

At work we still have the overlay as part of the board support package we created for the s6105. But I'd prefer to talk to someone at Stretch first before handing out copies. Unfortunately I'm on vacation right now and will be without internet access from tomorrow to Sunday.

Ping. Is that the only known platform for the s6000?

The only platform we know of.

These chips were showcased as H.264 encoders, so it is more likely to find them inside cameras, DVRs, and studio equipment. But there is no H.264 IP block inside the chips and their instruction set is generic (actually runtime reconfigurable), so they are not restricted to video processing.

Daniel

#10 lore raw
In reply to Wolfram Sang
Quoted 6 lines · Wolfram Sang
Quoted 5 lines · Daniel Glöckner
Quoted 4 lines · Oskar Schirmer
Quoted 2 lines · czankel

I might have asked you before, but do you still have the overlay for the S6000 somewhere laying around?

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

No, but maybe Daniel has?

At work we still have the overlay as part of the board support package we created for the s6105. But I'd prefer to talk to someone at Stretch first before handing out copies. Unfortunately I'm on vacation right now and will be without internet access from tomorrow to Sunday.

Ping. Is that the only known platform for the s6000?

After exchanging some mails with Stretch (now Exar), it is still uncertain if the Linux port ever made it into a product. As the chip is out of production, there won't be any new s6000 devices. Google turns up three press releases of companies using the s6000 in DVR devices, but these appear to have the chips on add-in cards.

The good news is that Exar doesn't mind me sharing the overlay. You can download it from this page: http://www.emlix.com/download/

I removed some files from the tarball:

create-config-pkgs
had a restrictive copyright header requiring written permission from Tensilica. It's a simple shell script grouping the other files for building various toolchain packages.

src/gdb/reg-xtensa.dat and src/binutils/xtensa-config.sh
had no license header and Exar could not easily determine the original licensing conditions. The first file basically contains the size and name of the first 176 registers in the "rmap" array. The other file just defines MAXPAGESIZE to a huge value. Well, it's nommu.

gnu-xcalibur/
Appeared to contain old copies of GNU libstdc++, libio, and libiberty. Most files were four years older than the Xtensa core headers. I doubt anyone would want to use these today.

Marc, according to the tarball someone with your name at Tensilica was involved in the creation of the overlay. Maybe you remember if any of these files is needed?

Trying to build CONFIG_XTENSA_PLATFORM_S6105 in mainline will fail. Mainline never accepted all of our patches and this apparently led to two arrays being mixed when 759c67e87bce was merged.

Best regards,

Daniel

Signature · 7 lines
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11,
Bertha-von-Suttner-Straße 9, 37085 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055

emlix - your embedded linux partner

A message that is not in the archive (sent off-list or not yet received): [email protected]

#12 lore raw

Hi Daniel,

Quoted 2 lines

After exchanging some mails with Stretch (now Exar), it is still uncertain if the Linux port ever made it into a product.

Thanks for keeping at it!

Quoted 2 lines

The good news is that Exar doesn't mind me sharing the overlay. You can download it from this page: http://www.emlix.com/download/

That is nice.

Quoted 3 lines

Trying to build CONFIG_XTENSA_PLATFORM_S6105 in mainline will fail. Mainline never accepted all of our patches and this apparently led to two arrays being mixed when 759c67e87bce was merged.

That not ;) Anyhow, my latest pull-request includes the removal of the s6000 I2C driver. There is the designware driver if anyone feels like it. It doesn't really look like there will be one, though. Sounds like this platform is a good candidate for removal, but I will leave this up to you guys...

Regards,

Wolfram

#13 lore raw
In reply to Oskar Schirmer
Quoted 10 lines
Quoted 9 lines

I recently discovered that the I2C core of the S6000 is basically a Designware IP core. For the latter we have a frequently used and updated i2c driver while the S6000 driver seems to bitrot. My wish is to remove the s6000 driver in favor of the DesignWare one. My question is if there is someone who could test such a change on real hardware? Grepping through sources, it looks to me like the only candidate in mainline is the s6105, yet its defconfig doesn't even have I2C activated? Can we remove this driver right away? Am I missing something?

Quoted 3 lines

Removing drivers without a replacement tested and running doesn't make much sense, except one chooses to drop support for the whole S6 thing right away. Which I don't support.

Huh? I explicitly asked for help to test the replacement driver in the first place. And was wondering why it is not in a defconfig. You know, it could have been broken, too.