Skip to contentSkip to conversation

Remove obsolete strict_strto calls

PATCH Superseded Daniel Walter 2 participants 2 messages May 26, 2014 – May 28, 2014

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/12 Remove obsolete strict_strto calls

From: Daniel Walter <[email protected]>
Subject: [PATCH 01/12] [arch/tile] replace strict_strto* call with kstrto*

remove obsolete calls to strict_strto* and replace them with kstrto* calls accordingly.

---
 arch/tile/kernel/setup.c  | 7 ++-----
 arch/tile/kernel/signal.c | 7 +++----
 arch/tile/kernel/traps.c  | 5 ++---
 arch/tile/mm/init.c       | 2 +-
 4 files changed, 8 insertions(+), 13 deletions(-)
arch/tile/kernel/setup.c +2 -5
index 74c9172..9ff0074 100644
@@ -228,13 +228,10 @@ early_param("isolnodes", setup_isolnodes);
 #if defined(CONFIG_PCI) && !defined(__tilegx__)
 static int __init setup_pci_reserve(char* str)
 {
-	unsigned long mb;
-
-	if (str == NULL || strict_strtoul(str, 0, &mb) != 0 ||
-	    mb > 3 * 1024)
+	if (str == NULL || kstrtouint(str, 0, &pci_reserve_mb) != 0 ||
+	    pci_reserve_mb > 3 * 1024)
 		return -EINVAL;
 
-	pci_reserve_mb = mb;
 	pr_info("Reserving %dMB for PCIE root complex mappings\n",
 		pci_reserve_mb);
 	return 0;
arch/tile/kernel/signal.c +3 -4
index 2d1dbf3..d1d026f 100644
@@ -321,14 +321,13 @@ int show_unhandled_signals = 1;
 
 static int __init crashinfo(char *str)
 {
-	unsigned long val;
 	const char *word;
 
 	if (*str == '\0')
-		val = 2;
-	else if (*str != '=' || strict_strtoul(++str, 0, &val) != 0)
+		show_unhandled_signals = 2;
+	else if (*str != '=' || kstrtoint(++str, 0, &show_unhandled_signals) != 0)
 		return 0;
-	show_unhandled_signals = val;
+
 	switch (show_unhandled_signals) {
 	case 0:
 		word = "No";
arch/tile/kernel/traps.c +2 -3
index 6b603d5..f3ceb63 100644
@@ -42,10 +42,9 @@ static int __init setup_unaligned_fixup(char *str)
 	 * will still parse the instruction, then fire a SIGBUS with
 	 * the correct address from inside the single_step code.
 	 */
-	long val;
-	if (strict_strtol(str, 0, &val) != 0)
+	if (kstrtoint(str, 0, &unaligned_fixup) != 0)
 		return 0;
-	unaligned_fixup = val;
+
 	pr_info("Fixups for unaligned data accesses are %s\n",
 	       unaligned_fixup >= 0 ?
 	       (unaligned_fixup ? "enabled" : "disabled") :
arch/tile/mm/init.c +1 -1
index 0fa1acf..df0e1c5 100644
@@ -912,7 +912,7 @@ static long __write_once initfree = 1;
 static int __init set_initfree(char *str)
 {
 	long val;
-	if (strict_strtol(str, 0, &val) == 0) {
+	if (kstrtol(str, 0, &val) == 0) {
 		initfree = val;
 		pr_info("initfree: %s free init pages\n",
 			initfree ? "will" : "won't");
Signature · 1 line
1.9.3
#1 lore raw
Quoted 6 lines · Daniel Walter

From: Daniel Walter<[email protected]>
Subject: [PATCH 01/12] [arch/tile] replace strict_strto* call with kstrto*

remove obsolete calls to strict_strto* and replace them with kstrto* calls accordingly.

Quoted 7 lines
---
  arch/tile/kernel/setup.c  | 7 ++-----
  arch/tile/kernel/signal.c | 7 +++----
  arch/tile/kernel/traps.c  | 5 ++---
  arch/tile/mm/init.c       | 2 +-
  4 files changed, 8 insertions(+), 13 deletions(-)

Thanks, taken into the tile tree.

Signature · 2 lines
Chris Metcalf, Tilera Corp.
http://www.tilera.com