Skip to contentSkip to conversation

staging: dgap: remove useless dgap_probe1() function

PATCH RESEND In review Daeseok Youn 2 participants 5 messages Jun 2, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/6 staging: dgap: remove useless dgap_probe1() function

The dgap_probe1() function is just calling dgap_found_board(). So it is removed and dgap_found_board() is called directly.

---
RESEND : this patch is included into newly serise of patches so renumbered and resend.

 drivers/staging/dgap/dgap.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
drivers/staging/dgap/dgap.c +1 -7
index 170d6f3..af78f6f 100644
@@ -76,7 +76,6 @@ static void dgap_poll_handler(ulong dummy);
 static int dgap_init_pci(void);
 static int dgap_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
 static void dgap_remove_one(struct pci_dev *dev);
-static int dgap_probe1(struct pci_dev *pdev, int card_type);
 static int dgap_do_remap(struct board_t *brd);
 static irqreturn_t dgap_intr(int irq, void *voidbrd);
 
@@ -577,7 +576,7 @@ static int dgap_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	if (rc)
 		return -EIO;
 
-	rc = dgap_probe1(pdev, ent->driver_data);
+	rc = dgap_found_board(pdev, ent->driver_data);
 	if (rc)
 		return rc;
 
@@ -585,11 +584,6 @@ static int dgap_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	return dgap_firmware_load(pdev, ent->driver_data);
 }
 
-static int dgap_probe1(struct pci_dev *pdev, int card_type)
-{
-	return dgap_found_board(pdev, card_type);
-}
-
 static void dgap_remove_one(struct pci_dev *dev)
 {
 	/* Do Nothing */
Signature · 1 line
1.7.1
#1 lore raw
Quoted 7 lines · Daeseok Youn

The dgap_probe1() function is just calling dgap_found_board(). So it is removed and dgap_found_board() is called directly.

---
RESEND : this patch is included into newly serise of patches so renumbered and resend.

Don't do this. Just assume that patch will be applied. Greg applies patches in first come, first serve order. If it doesn't apply then he sends an email to redo it.

Now these two first patch won't apply and he has to figure out why and it just messes up the process.

Also don't try to fix this now by resending again without the first two patches. That just creates more confusion.

regards,
dan carpenter

#2 lore raw

Hi, Dan.

2014-06-02 16:30 GMT+09:00 Dan Carpenter <[email protected]>:

Quoted 12 lines · Daeseok Youn
Quoted 7 lines

The dgap_probe1() function is just calling dgap_found_board(). So it is removed and dgap_found_board() is called directly.

---
RESEND : this patch is included into newly serise of patches so renumbered and resend.

Don't do this. Just assume that patch will be applied. Greg applies patches in first come, first serve order. If it doesn't apply then he sends an email to redo it.

Ok. I will not do like this again. sorry,
I should wait for merge first two patches or send my patches without the first two patches.

Quoted 6 lines

Now these two first patch won't apply and he has to figure out why and it just messes up the process.

Also don't try to fix this now by resending again without the first two patches. That just creates more confusion.

OK. I will wait for message from greg.
Thanks.

regards,
Daeseok Youn

Quoted 4 lines

regards,
dan carpenter

#3 lore raw
Quoted 12 lines · DaeSeok Youn

Hi, Dan.

2014-06-02 16:30 GMT+09:00 Dan Carpenter <[email protected]>:

Quoted 9 lines · Daeseok Youn
Quoted 7 lines

The dgap_probe1() function is just calling dgap_found_board(). So it is removed and dgap_found_board() is called directly.

---
RESEND : this patch is included into newly serise of patches so renumbered and resend.

Quoted 6 lines
Quoted 3 lines

Don't do this. Just assume that patch will be applied. Greg applies patches in first come, first serve order. If it doesn't apply then he sends an email to redo it.

Ok. I will not do like this again. sorry,
I should wait for merge first two patches or send my patches without the first two patches.

Don't bother waiting. Just send the next patches. The first ones were good patches, so Greg will apply them. It is a very predictable process.

regards,
dan carpenter

#4 lore raw

2014-06-02 19:13 GMT+09:00 Dan Carpenter <[email protected]>:

Quoted 16 lines · DaeSeok Youn
Quoted 15 lines

Hi, Dan.

2014-06-02 16:30 GMT+09:00 Dan Carpenter <[email protected]>:

Quoted 12 lines · Daeseok Youn
Quoted 7 lines

The dgap_probe1() function is just calling dgap_found_board(). So it is removed and dgap_found_board() is called directly.

---
RESEND : this patch is included into newly serise of patches so renumbered and resend.

Don't do this. Just assume that patch will be applied. Greg applies patches in first come, first serve order. If it doesn't apply then he sends an email to redo it.

Quoted 7 lines
Quoted 3 lines

Ok. I will not do like this again. sorry,
I should wait for merge first two patches or send my patches without the first two patches.

Don't bother waiting. Just send the next patches. The first ones were good patches, so Greg will apply them. It is a very predictable process.

OK. I will send the next patches.

Thanks.

regards,
Daeseok Youn

Quoted 4 lines

regards,
dan carpenter