Skip to contentSkip to conversation

wil6210: improve debug for WMI receive

DISCUSSION Dan Carpenter 2 participants 2 messages Jun 9, 2014

lore
Share & tools
lore
#0 lore raw

Hello Vladimir Kondratiev,

The patch a715c7ddd65a: "wil6210: improve debug for WMI receive" from May 29, 2014, leads to the following static checker warning:

	drivers/net/wireless/ath/wil6210/wmi.c:746 wmi_recv_cmd()
	info: ignoring unreachable code.

drivers/net/wireless/ath/wil6210/wmi.c
739 spin_unlock_irqrestore(&wil->wmi_ev_lock, flags);
740 {
741 int q = queue_work(wil->wmi_wq,
742 &wil->wmi_event_worker);
743 wil_dbg_wmi(wil, "queue_work -> %d\n", q);
744 }
745 }
746 if (n > 1)

                ^^^^^^^^^^

We never reach this if statemtent.

   747                  wil_dbg_wmi(wil, "%s -> %d events processed\n", __func__, n);
   748  }

regards,
dan carpenter

#1 lore raw
Quoted 3 lines · Dan Carpenter
   746          if (n > 1)
                ^^^^^^^^^^

We never reach this if statemtent.

Dan,

Thanks for this. I'll upload fix shortly.
Caused by the missed chunk in rebase.

Thanks, Vladimir