Skip to contentSkip to conversation

gma500: remove duplicate FB_REG09 define

PATCH In review Dan Carpenter 4 participants 4 messages Jun 9, 2014 – Jun 10, 2014

Subsystems (4)
DRM drivers DRM misc Kernel janitors DRM drivers for GMA500 (Poulsbo, Moorestown and derivative chipsets)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 gma500: remove duplicate FB_REG09 define

The FB_REG09 define is cut and pasted twice so we can remove the second instance.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/gma500/mid_bios.c +0 -1
index a97e38e..d75ecb3 100644
@@ -39,7 +39,6 @@ static void mid_get_fuse_settings(struct drm_device *dev)
 #define FB_REG06 0xD0810600
 #define FB_MIPI_DISABLE  (1 << 11)
 #define FB_REG09 0xD0810900
-#define FB_REG09 0xD0810900
 #define FB_SKU_MASK  0x7000
 #define FB_SKU_SHIFT 12
 #define FB_SKU_100 0
#1 lore raw

Patrik, Alan -

Should you add a MAINTAINERS entry for gma500 with one or both of you as maintainers? What's the status?

BR,
Jani.

Quoted 21 lines · Dan Carpenter

The FB_REG09 define is cut and pasted twice so we can remove the second instance.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/gma500/mid_bios.c +0 -1
index a97e38e..d75ecb3 100644
@@ -39,7 +39,6 @@ static void mid_get_fuse_settings(struct drm_device *dev)
 #define FB_REG06 0xD0810600
 #define FB_MIPI_DISABLE  (1 << 11)
 #define FB_REG09 0xD0810900
-#define FB_REG09 0xD0810900
 #define FB_SKU_MASK  0x7000
 #define FB_SKU_SHIFT 12
 #define FB_SKU_100 0

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
maintainer
#2 lore raw
Quoted 8 lines · Jani Nikula

Patrik, Alan -

Should you add a MAINTAINERS entry for gma500 with one or both of you as maintainers? What's the status?

BR,
Jani.

Hi Jani

Adding an entry would make people think that I have time to spend on gma500 development or is in some way responsible for it. At the moment, that is sadly not the case. I have a few things on my todo-list which I intend to fix but after that I would much rather work on something more productive.

My gma500 itch has been scratched for quite a while and perhaps it's time to move on.

Regards
Patrik

Quoted 27 lines · Dan Carpenter
Quoted 17 lines

The FB_REG09 define is cut and pasted twice so we can remove the second instance.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/gma500/mid_bios.c +0 -1
index a97e38e..d75ecb3 100644
@@ -39,7 +39,6 @@ static void mid_get_fuse_settings(struct drm_device *dev)
 #define FB_REG06 0xD0810600
 #define FB_MIPI_DISABLE  (1 << 11)
 #define FB_REG09 0xD0810900
-#define FB_REG09 0xD0810900
 #define FB_SKU_MASK  0x7000
 #define FB_SKU_SHIFT 12
 #define FB_SKU_100 0
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Jani Nikula, Intel Open Source Technology Center

#3 lore raw
Quoted 4 lines

Adding an entry would make people think that I have time to spend on gma500 development or is in some way responsible for it. At the moment, that is sadly not the case. I have a few things on my todo-list which I intend to fix but after that I would much rather work on something more productive.

A wise man indeed.

I'll try and keep an eye on it for minor fixes but hopefully its "done". Apart from one person trying to port Linux to the Lenovo Tablet 2 I don't think there is anything that is likely to happen here new ?

Alan