Skip to contentSkip to conversation

kexec-save-pg_head_mask-in-vmcoreinfo.patch

DISCUSSION Petr Tesarik 2 participants 2 messages Jun 17, 2014 5 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 46 lines · On Thu, 12 Jun 2014 17:04:36 +0200 Petr Tesarik <[email protected]> wrote:
Quoted 43 lines · On Wed, 11 Jun 2014 13:24:22 -0400 Vivek Goyal <[email protected]> wrote:
Quoted 42 lines · Petr Tesarik
Quoted 38 lines · On Tue, 10 Jun 2014 11:35:54 -0400 Vivek Goyal <[email protected]> wrote:
Quoted 18 lines · Andrew Morton

Guys, could you please review this one?

Thanks.

From: Petr Tesarik <[email protected]>
Subject: kexec: save PG_head_mask in VMCOREINFO

To allow filtering of huge pages, makedumpfile must be able to identify them in the dump. This can be done by checking the appropriate page flag, so communicate its value to makedumpfile through the VMCOREINFO interface.

There's only one small catch. Depending on how many page flags are available on a given architecture, this bit can be called PG_head or PG_compound.

Quoted 6 lines

I sent a similar patch back in 2012, but Eric Biederman did not like using an #ifdef. So, this time I'm adding a common symbol (PG_head_mask) instead.

See https://lkml.org/lkml/2012/11/28/91 for the previous version.

Hi Petr,

I went through previous conversation and personally I like that patch better.

We already have so many exports in vmcoreinfo which are conditional based on config options. Adding one more should be just fine. And as you said that it should not bitrot as it will most likely lead to complication failures if things shift around.

Does this patch compile with !CONFIG_PAGEFLAGS_EXTENDED. I did not see a definition of PG_head_mask in that case.

Quoted 8 lines
Quoted 8 lines
Quoted 2 lines

With !CONFIG_PAGEFLAGS_EXTENDED, the definition of PG_head_mask is already there (and has been for quite some time).

Oh.., I had not noticed that. Thanks.

Quoted 3 lines
Quoted 3 lines

So I would say post your patch again, I will ack it. CC Eric and hopefully he does not have any objections to it.

Oh, it seems you're still waiting for Eric's opinion, but I didn't notice that he wasn't in Cc yet.

Quoted 10 lines
Quoted 10 lines
Quoted 2 lines

Er, I'm not sure which patch you mean. The original one (with conditional PG_head/PG_compound), or the new one (with PG_head_mask)?

Given PG_head_mask is already defined for !CONFIG_PAGEFLAGS_EXTENDED, I am fine with this version too.

So bottom line, I am fine with either version. Given that Andrew already seems to have this one queued, I will ack this one.

Eric, based on Vivek's feedback, do you have any objections to the following patch:

http://ozlabs.org/~akpm/mmotm/broken-out/kexec-save-pg_head_mask-in-vmcoreinfo.patch

Thanks,
Petr Tesarik

Quoted 48 lines

Thank you!

As a side note, I personally like this new version better, because it does not propagate the differences between CONFIG_PAGEFLAGS_EXTENDED and !CONFIG_PAGEFLAGS_EXTENDED to VMCOREINFO (and consequently to all tools that want to use it).

Petr Tesarik

Quoted 39 lines
Quoted 39 lines
Quoted 39 lines
Quoted 39 lines
Cc Eric Biederman <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Fengguang Wu <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Shaohua Li <[email protected]>
Cc Alexey Kardashevskiy <[email protected]>
Cc Sasha Levin <[email protected]>
Cc Vivek Goyal <[email protected]>

---

 include/linux/page-flags.h |    3 +++
 kernel/kexec.c             |    1 +
 2 files changed, 4 insertions(+)

diff -puN include/linux/page-flags.h~kexec-save-pg_head_mask-in-vmcoreinfo include/linux/page-flags.h

include/linux/page-flags.h renamed from include/linux/page-flags.h~kexec-save-pg_head_mask-in-vmcoreinfo +3 -0
@@ -350,6 +350,9 @@ static inline void ClearPageCompound(str
 	ClearPageHead(page);
 }
 #endif
+
+#define PG_head_mask ((1L << PG_head))
+
 #else
 /*
  * Reduce page flag use as much as possible by overlapping

diff -puN kernel/kexec.c~kexec-save-pg_head_mask-in-vmcoreinfo kernel/kexec.c

kernel/kexec.c renamed from kernel/kexec.c~kexec-save-pg_head_mask-in-vmcoreinfo +1 -0
@@ -1617,6 +1617,7 @@ static int __init crash_save_vmcoreinfo_
 #ifdef CONFIG_MEMORY_FAILURE
 	VMCOREINFO_NUMBER(PG_hwpoison);
 #endif
+	VMCOREINFO_NUMBER(PG_head_mask);
 	VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE);
 
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
kernel/kexec.c renamed from kernel/kexec.c~kexec-save-pg_head_mask-in-vmcoreinfo +0 -0
 	arch_crash_save_vmcoreinfo();

_

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#6 lore raw
Quoted 52 lines · Petr Tesarik
Quoted 49 lines · On Thu, 12 Jun 2014 17:04:36 +0200 Petr Tesarik <[email protected]> wrote:
Quoted 46 lines · On Wed, 11 Jun 2014 13:24:22 -0400 Vivek Goyal <[email protected]> wrote:
Quoted 44 lines · Petr Tesarik
Quoted 31 lines · On Tue, 10 Jun 2014 11:35:54 -0400 Vivek Goyal <[email protected]> wrote:
Quoted 18 lines · Andrew Morton

Guys, could you please review this one?

Thanks.

From: Petr Tesarik <[email protected]>
Subject: kexec: save PG_head_mask in VMCOREINFO

To allow filtering of huge pages, makedumpfile must be able to identify them in the dump. This can be done by checking the appropriate page flag, so communicate its value to makedumpfile through the VMCOREINFO interface.

There's only one small catch. Depending on how many page flags are available on a given architecture, this bit can be called PG_head or PG_compound.

Quoted 6 lines

I sent a similar patch back in 2012, but Eric Biederman did not like using an #ifdef. So, this time I'm adding a common symbol (PG_head_mask) instead.

See https://lkml.org/lkml/2012/11/28/91 for the previous version.

Hi Petr,

I went through previous conversation and personally I like that patch better.

Quoted 7 lines

We already have so many exports in vmcoreinfo which are conditional based on config options. Adding one more should be just fine. And as you said that it should not bitrot as it will most likely lead to complication failures if things shift around.

Does this patch compile with !CONFIG_PAGEFLAGS_EXTENDED. I did not see a definition of PG_head_mask in that case.

With !CONFIG_PAGEFLAGS_EXTENDED, the definition of PG_head_mask is already there (and has been for quite some time).

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines

Oh.., I had not noticed that. Thanks.

Quoted 3 lines
Quoted 3 lines

So I would say post your patch again, I will ack it. CC Eric and hopefully he does not have any objections to it.

Oh, it seems you're still waiting for Eric's opinion, but I didn't notice that he wasn't in Cc yet.

That was in the context of when I said repost the old patch. Later I agreed to existing patch (The one with PG_head_mask) and I have acked it.

Thanks
Vivek

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec