Skip to contentSkip to conversation

amd-xgbe: unwind on error in xgbe_mdio_register()

PATCH Applied Dan Carpenter 3 participants 3 messages Jun 11, 2014

Subsystems (4)
Networking Network drivers Kernel janitors AMD xgbe driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 amd-xgbe: unwind on error in xgbe_mdio_register()

There is a typo here so we return directly instead of unwinding.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/amd/xgbe/xgbe-mdio.c +1 -1
index 52bbdbf..ea7a5d6 100644
@@ -367,7 +367,7 @@ int xgbe_mdio_register(struct xgbe_prv_data *pdata)
 
 	if (!phydev->drv || (phydev->drv->phy_id = 0)) {
 		netdev_err(netdev, "phy_id not valid\n");
-		return -ENODEV;
+		ret = -ENODEV;
 		goto err_phy_connect;
 	}
 	DBGPR("  phy_connect_direct succeeded for PHY %s, link=%d\n",
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Dan Carpenter

There is a typo here so we return directly instead of unwinding.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Tom Lendacky <[email protected]>
Quoted 15 lines
drivers/net/ethernet/amd/xgbe/xgbe-mdio.c +1 -1
index 52bbdbf..ea7a5d6 100644
@@ -367,7 +367,7 @@ int xgbe_mdio_register(struct xgbe_prv_data *pdata)
 
  	if (!phydev->drv || (phydev->drv->phy_id = 0)) {
  		netdev_err(netdev, "phy_id not valid\n");
-		return -ENODEV;
+		ret = -ENODEV;
  		goto err_phy_connect;
  	}
  	DBGPR("  phy_connect_direct succeeded for PHY %s, link=%d\n",