Skip to contentSkip to conversation

net: return actual error on register_queue_kobjects

DISCUSSION Dan Carpenter 3 participants 3 messages Jun 19, 2014 – Jun 20, 2014

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

Hello Jie Liu,

The patch d36a4f4b4723: "net: return actual error on register_queue_kobjects" from Jun 17, 2014, leads to the following static checker warning:

	net/core/net-sysfs.c:1203 register_queue_kobjects()
	warn: 'net->queues_kset' isn't an ERR_PTR

net/core/net-sysfs.c
1200 #ifdef CONFIG_SYSFS
1201 net->queues_kset = kset_create_and_add("queues",

                                   ^^^^^^^^^^^^^^^^^^^

This function returns a NULL on error doesn't it? In linux-next it does. The patch description is not clear.

  1202              NULL, &net->dev.kobj);
  1203          if (IS_ERR(net->queues_kset))
  1204                  return PTR_ERR(net->queues_kset);
  1205          real_rx = net->real_num_rx_queues;
  1206  #endif

regards,
dan carpenter

#1 lore raw
Quoted 9 lines · Dan Carpenter

Hello Jie Liu,

The patch d36a4f4b4723: "net: return actual error on register_queue_kobjects" from Jun 17, 2014, leads to the following static checker warning:

        net/core/net-sysfs.c:1203 register_queue_kobjects()
        warn: 'net->queues_kset' isn't an ERR_PTR
Quoted 6 lines

net/core/net-sysfs.c
1200 #ifdef CONFIG_SYSFS
1201 net->queues_kset = kset_create_and_add("queues",

                                   ^^^^^^^^^^^^^^^^^^^

This function returns a NULL on error doesn't it? In linux-next it does. The patch description is not clear.

that patch is broken and should be reverted as Jeff said:

--
From: Jeff Liu <[email protected]>

Quoted 2 lines

You will have to watch very carefully to ensure that those patches do not now get accepted, as they will break the existing code.

Ok, and I'll inform every other maintainers do not apply their patch individually.

Cheers,
-Jeff

--

From: Jeff Liu <[email protected]>
Yes, could you please remove this patch? sorry for the convenient!

--

maintainer
#2 lore raw
In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Fri, 20 Jun 2014 00:28:40 +0300

Quoted 3 lines

The patch d36a4f4b4723: "net: return actual error on register_queue_kobjects" from Jun 17, 2014, leads to the following static checker warning:

I've reverted it from my tree, thanks.