Skip to contentSkip to conversation

mmc: sdhci-bcm-kona: | vs & typo in debug code

PATCH In review Dan Carpenter 2 participants 2 messages Jun 20, 2014

Subsystems (4)
Kernel janitors MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver Broadcom BCM281XX/BCM11XXX/BCM216XX Arm architecture
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 mmc: sdhci-bcm-kona: | vs & typo in debug code

The debug printk says that 8bit is always true because of a '|' vs '&' typo.

Signed-off-by Dan Carpenter <[email protected]>
drivers/mmc/host/sdhci-bcm-kona.c +1 -1
index dd780c3..2d3f3c0 100644
@@ -290,7 +290,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
 		host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
 
 	dev_dbg(dev, "is_8bit=%c\n",
-		(host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
+		(host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
 
 	ret = sdhci_bcm_kona_sd_reset(host);
 	if (ret)
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Dan Carpenter

The debug printk says that 8bit is always true because of a '|' vs '&' typo.

Signed-off-by Dan Carpenter <[email protected]>
Acked-by Matt Porter <[email protected]>
Quoted 14 lines
drivers/mmc/host/sdhci-bcm-kona.c +1 -1
index dd780c3..2d3f3c0 100644
@@ -290,7 +290,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
 		host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
 
 	dev_dbg(dev, "is_8bit=%c\n",
-		(host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
+		(host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
 
 	ret = sdhci_bcm_kona_sd_reset(host);
 	if (ret)