Skip to contentSkip to conversation

mpt2sas: Added driver module parameter max_msix_vectors

PATCH RESEND Superseded Reddy, Sreekanth 2 participants 3 messages Jun 25, 2014 – Jul 13, 2014 SCSI

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/10 mpt2sas: Added driver module parameter max_msix_vectors

Added driver module parameter max_msix_vectors. Using this module parameter the maximum number of MSI-X vectors could be set.

The number of MSI-X vectors used would be the minimum of MSI-X vectors supported by the HBA, the number of CPU cores and the value set to max_msix_vectors module parameters.

---
 drivers/scsi/mpt2sas/mpt2sas_base.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
drivers/scsi/mpt2sas/mpt2sas_base.c +14 -0
index bde63f7..ed810fb 100644
@@ -80,6 +80,10 @@ static int msix_disable = -1;
 module_param(msix_disable, int, 0);
 MODULE_PARM_DESC(msix_disable, " disable msix routed interrupts (default=0)");
 
+static int max_msix_vectors = -1;
+module_param(max_msix_vectors, int, 0);
+MODULE_PARM_DESC(max_msix_vectors, " max msix vectors ");
+
 static int mpt2sas_fwfault_debug;
 MODULE_PARM_DESC(mpt2sas_fwfault_debug, " enable detection of firmware fault "
 	"and halt firmware - (default=0)");
@@ -1420,6 +1424,16 @@ _base_enable_msix(struct MPT2SAS_ADAPTER *ioc)
 	ioc->reply_queue_count = min_t(int, ioc->cpu_count,
 	    ioc->msix_vector_count);
 
+	if (max_msix_vectors > 0) {
+		ioc->reply_queue_count = min_t(int, max_msix_vectors,
+		    ioc->reply_queue_count);
+		ioc->msix_vector_count = ioc->reply_queue_count;
+	}
+
+	printk(MPT2SAS_INFO_FMT
+	"MSI-X vectors supported: %d, no of cores: %d, max_msix_vectors: %d\n",
+	 ioc->name, ioc->msix_vector_count, ioc->cpu_count, max_msix_vectors);
+
 	entries = kcalloc(ioc->reply_queue_count, sizeof(struct msix_entry),
 	    GFP_KERNEL);
 	if (!entries) {
Signature · 1 line
1.7.1
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sreekanth" == Reddy, Sreekanth <[email protected]> writes:

Sreekanth> Added driver module parameter max_msix_vectors. Using this Sreekanth> module parameter the maximum number of MSI-X vectors could be Sreekanth> set.

Sreekanth> The number of MSI-X vectors used would be the minimum of Sreekanth> MSI-X vectors supported by the HBA, the number of CPU cores Sreekanth> and the value set to max_msix_vectors module parameters.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
Reviewed-by on v1 1/10
#2 lore raw
In reply to Reddy, Sreekanth
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sreekanth" == Reddy, Sreekanth <[email protected]> writes:

Sreekanth> Added driver module parameter max_msix_vectors. Using this Sreekanth> module parameter the maximum number of MSI-X vectors could be Sreekanth> set.

Sreekanth> The number of MSI-X vectors used would be the minimum of Sreekanth> MSI-X vectors supported by the HBA, the number of CPU cores Sreekanth> and the value set to max_msix_vectors module parameters.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering