Skip to contentSkip to conversation

rtl_nic firmware error in 3.16

DISCUSSION Ken Moffat 1 participant 2 messages Jun 26, 2014 – Jul 3, 2014

lore
Share & tools
lore

Ken Moffat

author
#0 lore raw

Hi,

I'm getting 15 lines of the following in -rc2

/bin/sh: firmware/rtl_nic/rtl8168e-3.fw.gen.S: No such file or directory

followed by
firmware/Makefile:185: recipe for target 'firmware/rtl_nic/rtl8168e-3.fw.gen.S' failed make[1]: *** [firmware/rtl_nic/rtl8168e-3.fw.gen.S] Error 1

I've now tried bisecting this twice, from v3.15 to v3.16-rc2 but
each time the only bad version was v3.16-rc2 itself which is clearly not true.

The relevant part of my .config is probably in here:

#
# Generic Driver Options
#
CONFIG_UEVENT_HELPER=y
CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
CONFIG_DEVTMPFS=y
CONFIG_DEVTMPFS_MOUNT=y
# CONFIG_STANDALONE is not set
CONFIG_PREVENT_FIRMWARE_BUILD=y
CONFIG_FW_LOADER=y
# CONFIG_FIRMWARE_IN_KERNEL is not set
CONFIG_EXTRA_FIRMWARE="radeon/R600_rlc.bin radeon/RS780_pfp.bin radeon/RS780_me.bin rtl_nic/rtl8168e-3.fw" CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware"
CONFIG_FW_LOADER_USER_HELPER=y
# CONFIG_DEBUG_DRIVER is not set
# CONFIG_DEBUG_DEVRES is not set
# CONFIG_SYS_HYPERVISOR is not set
# CONFIG_GENERIC_CPU_DEVICES is not set
CONFIG_GENERIC_CPU_AUTOPROBE=y
CONFIG_DMA_SHARED_BUFFER=y

and the external firmware is in /lib/firmware :

ken@ac4tv ~ $ls -l /lib/firmware/rtl_nic/ total 4
-rw-r--r-- 1 root root 2804 Feb 18 18:03 rtl8168e-3.fw

So I assume something is erroneously trying to recreate it.

For the second run, I tried using 'make clean' on each build, and
then after a while I changed to 'make mrproper'. Perhaps I should have used 'mrproper' from the start (never needed it before, and it does normally slow things down when you approach the guilty commit).

I have now pulled the -rc1 tarball and confirmed that the problem
is present there, but this is doing my head in, so I thought I would ask if anyone else is hitting this ?

ĸen

Signature · 2 lines
Nanny Ogg usually went to bed early. After all, she was an old lady.
Sometimes she went to bed as early as 6 a.m.
author
#1 lore raw
Quoted 50 lines · Ken Moffat

Hi,

I'm getting 15 lines of the following in -rc2

/bin/sh: firmware/rtl_nic/rtl8168e-3.fw.gen.S: No such file or directory

followed by
firmware/Makefile:185: recipe for target 'firmware/rtl_nic/rtl8168e-3.fw.gen.S' failed make[1]: *** [firmware/rtl_nic/rtl8168e-3.fw.gen.S] Error 1

I've now tried bisecting this twice, from v3.15 to v3.16-rc2 but
each time the only bad version was v3.16-rc2 itself which is clearly not true.

The relevant part of my .config is probably in here:

#
# Generic Driver Options
#
CONFIG_UEVENT_HELPER=y
CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
CONFIG_DEVTMPFS=y
CONFIG_DEVTMPFS_MOUNT=y
# CONFIG_STANDALONE is not set
CONFIG_PREVENT_FIRMWARE_BUILD=y
CONFIG_FW_LOADER=y
# CONFIG_FIRMWARE_IN_KERNEL is not set
CONFIG_EXTRA_FIRMWARE="radeon/R600_rlc.bin radeon/RS780_pfp.bin radeon/RS780_me.bin rtl_nic/rtl8168e-3.fw" CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware"
CONFIG_FW_LOADER_USER_HELPER=y
# CONFIG_DEBUG_DRIVER is not set
# CONFIG_DEBUG_DEVRES is not set
# CONFIG_SYS_HYPERVISOR is not set
# CONFIG_GENERIC_CPU_DEVICES is not set
CONFIG_GENERIC_CPU_AUTOPROBE=y
CONFIG_DMA_SHARED_BUFFER=y

and the external firmware is in /lib/firmware :

ken@ac4tv ~ $ls -l /lib/firmware/rtl_nic/ total 4
-rw-r--r-- 1 root root 2804 Feb 18 18:03 rtl8168e-3.fw

So I assume something is erroneously trying to recreate it.

For the second run, I tried using 'make clean' on each build, and
then after a while I changed to 'make mrproper'. Perhaps I should have used 'mrproper' from the start (never needed it before, and it does normally slow things down when you approach the guilty commit).

Quoted 5 lines

I have now pulled the -rc1 tarball and confirmed that the problem
is present there, but this is doing my head in, so I thought I would ask if anyone else is hitting this ?

ĸen

Update, just in case anybody cares.

I still saw it on -rc3, an attempt to build using what was in linus'
tree the last time I pulled it (a bit after rc2) showed it once, and bisecting between 3.15-rc8 and 3.16-rc1 with 'make mrproper' on each build again blamed the version I labelled as bad, i.e. -rc1.

So, I dropped it from my config for -rc3 to see if it would boot
without this. It does, and shows no sign of wanting the firmware.

Weird. I'm _fairly_ sure that an older kernel (some time after I
first put this box together) complained that this firmware was missing (but appeared to still work), which is why I first added it.

But since -rc3 is happy without this firmware, I don't have a
problem.

ĸen

Signature · 2 lines
Nanny Ogg usually went to bed early. After all, she was an old lady.
Sometimes she went to bed as early as 6 a.m.