Skip to contentSkip to conversation

staging: dgap: remove redundant error value check

PATCH RESEND New Daeseok Youn 1 participant 1 message Jul 15, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/8 staging: dgap: remove redundant error value check

The retval in dgap_block_til_ready() is initialized to zero, and if no error has occurred in this function, the retval has a zero. So it doesn't need to check "retval" itself.

---
RESEND: Adds Mark to TO list and CC list for checking send this email properly to him.

 drivers/staging/dgap/dgap.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)
drivers/staging/dgap/dgap.c +1 -4
index 32988a8..10bd0f2 100644
@@ -2181,10 +2181,7 @@ static int dgap_block_til_ready(struct tty_struct *tty, struct file *file,
 
 	spin_unlock_irqrestore(&ch->ch_lock, lock_flags);
 
-	if (retval)
-		return retval;
-
-	return 0;
+	return retval;
 }
 
 /*
Signature · 1 line
1.7.1