Skip to contentSkip to conversation

WMI: Remove unnecessary null test

PATCH New Himangi Saraogi 1 participant 1 message Jul 15, 2014 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 WMI: Remove unnecessary null test

This patch removes the null test on block. block is initialized at the beginning of the function to &wblock->gblock. Since wblock is dereferenced prior to the null test, wblock must be a valid pointer, and &wblock->gblock cannot be null.

The following Coccinelle script is used for detecting the change:

@r@
expression e,f;
identifier g,y;
statement S1,S2;
@@

*e = &f->g
<+...
f->y
...+>
*if (e != NULL || ...)
S1 else S2

---
To send to: Matthew Garrett <[email protected]>,[email protected],[email protected]

 drivers/platform/x86/wmi.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/platform/x86/wmi.c +0 -4
index 43d1329..737e56d 100644
@@ -256,10 +256,6 @@ static acpi_status wmi_method_enable(struct wmi_block *wblock, int enable)
 	block = &wblock->gblock;
 	handle = wblock->handle;
 
-	if (!block)
-		return AE_NOT_EXIST;
-
-
 	snprintf(method, 5, "WE%02X", block->notify_id);
 	status = acpi_execute_simple_method(handle, method, enable);
 
Signature · 1 line
1.9.1